Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
statistics.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 May 2008 at 14:45 UTC
Updated:
3 Jan 2012 at 19:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
siliconmind commentedI'm sorry, i've just noticed that i had attached a wrong patch file :/
here is correct one.
Comment #2
samirnassar commentedSince this has new features it won't go into Drupal until Drupal 7. Reroll against HEAD please.
Comment #3
gpk commentedRelated: http://drupal.org/node/18013.
[update - the URL alias is now working for the Statistics Filtering project. http://drupal.org/project/statistics_filter ]
Comment #4
gpk commentedResetting version.
Comment #5
spiffyd commentedI am using 6.3. I ran your patch (statistics-extended-2.patch) and it doesn't work. Suggestions?
Here's the result:
can't find file to patch at input line 4
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |diff -urp statistics/statistics.admin.inc 6.x/statistics/statistics.admin.inc
> |--- statistics/statistics.admin.inc 2008-01-08 10:35:42.000000000 +0100
> |+++ 6.x/statistics
Comment #6
gpk commentedThe patch is trying to amend a file called "6.x/statistics/statistics.admin.inc". Maybe edit the patch to remove the leading 6.x/
Comment #7
spiffyd commented@gpk
Thanks! Your suggestions worked. However, I should note that the patch should be placed in the modules directory and not anywhere else.
Comment #8
gpk commentedYes, the patch is not in the right format to be applied from the main Drupal folder, i.e. it's not how it should be.
Re-opening the issue since although your problem is fixed, this feature is not in core yet nor has been rejected by the community.
Comment #9
spiffyd commentedAs basic as it seems, this patch NEEDS to be in CORE. It's a must...
Comment #10
siliconmind commentedsorry for malformed patch file - patching drupal is not the thing i do on daily basis ;)
anyway, i'm quite overrun with a lot of work now - can someone please reroll this patch for D7? It seems like this might come in handy for some users. unfortunately i won't be able to install D7 and create new patch for some time :(
if someone needs a bit of motivation: i've been using this patch on my D6 for some time now. it performs very well as long as you keep your filters up to date (mainly user agent filter). using it makes statistics Just Work™ for small sites with low number of visitors.
Comment #11
millions commentedIs it possible to use this patch for drupal 5.x?
Comment #12
gpk commentedNot sure if the patch will work on 5.x, even after accounting for #6.
But #3 http://drupal.org/node/255769#comment-837557 may provide a way forward.
Comment #13
spiffyd commented#1's patch works wonders but it generates an error as described here: http://drupal.org/node/362012
In short, it's not compatible with NORMAL page caching. Someone should look into this...
Comment #14
dave reidHas anyone here seen the Statistics Advanced Settings module? BTW, this is not a bug report, it's a feature request. New features can only be accepted for 7.x, so please don't change the version.
Comment #15
spiffyd commentedDave,
What's the difference between the Statistics Advanced Settings module and this patch? Is the module compatible with Page Caching in 6.x?
Comment #16
dave reidCheck out the features on the project page. If there's not a feature you want for 6.x, file a feature request and I'll take a look at it. And yes, it's compatible with normal page caching.
Comment #17
kattekrab commentedIs this a dupe of #696: Add filter to logs and referrer lists ?
Comment #18
siliconmind commentedBasically it's the same issue. Only that #696: Add filter to logs and referrer lists is just a discussion on what to do instead of providing real solution ;) Right now I'm playing with D7 and will probably provide appropriate patch for it. Unfortunately I don't think it will be included with the official drupal release :(