Download & Extend
Issues

Allow node_load($nid)

Posted by chx on June 23, 2005 at 6:37pm
Project:Drupal core
Component:node system
Category:feature request
Priority:normal
Assigned:chx
Status:closed (fixed)

Issue Summary

I am fed up writing node_load(array('nid' => $nid)) all the time.

BTW. if this is accepted, next is node_view to accept a $nid.

AttachmentSizeStatusTest resultOperations
node_load.patch2.23 KBIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by chx on June 23, 2005 at 6:41pm
AttachmentSizeStatusTest resultOperations
node_load_0.patch2.23 KBIgnored: Check issue status.NoneNone

#2

Posted by adrian on June 23, 2005 at 6:53pm

I am going to +1 this.

node_load(x) is much more natural to type. Having it use an array if found is useful too though.

#3

Posted by chx on July 1, 2005 at 5:00pm

Dries, if I remember correctly, you favoured this approach.

AttachmentSizeStatusTest resultOperations
node_load_1.patch27.89 KBIgnored: Check issue status.NoneNone

#4

Posted by chx on July 1, 2005 at 5:07pm

PHPdoc.

AttachmentSizeStatusTest resultOperations
node_load_2.patch27.97 KBIgnored: Check issue status.NoneNone

#5

Posted by Jose Reyero on July 1, 2005 at 5:14pm

+1
It's not only about lazy developers -which I am ;-)- it's also about shorter code => less errors, easier to catch

#6

Posted by chx on July 1, 2005 at 5:17pm

The patch and its consequences makes me love the version at http://drupal.org/node/25634#comment-33584 more, but Dries will be the one to decide.

#7

Posted by chx on July 1, 2005 at 5:31pm

A few things slipped in from another patch which should not be here.

AttachmentSizeStatusTest resultOperations
node_load_3.patch18.95 KBIgnored: Check issue status.NoneNone

#8

Posted by chx on July 1, 2005 at 5:33pm

Same problem as above.

AttachmentSizeStatusTest resultOperations
node_load_4.patch15.31 KBIgnored: Check issue status.NoneNone

#9

Posted by ezheidtmann on July 15, 2005 at 5:10am

I like this! Is there a similar issue for user_load()?

#10

Posted by Steven on July 16, 2005 at 6:33am

I definitely prefer the version where we simply allow $conditions to be passed as an integer, rather than introducing additional parameters.

It matches PHP's convention of having "mixed" argument types for some functions for shorthands (e.g. str_replace allows array arguments to compact multiple replacements in one statement). And not unimportant: it does not break backwards compatibility for what it essentially syntactic sugar.

#11

Posted by chx on July 16, 2005 at 7:58am

Steven. Dries did not like that version hence the additional parameter.

Dries, now that even Steven is on my side, would you please reconsider :) ?

#12

Posted by adrian on July 16, 2005 at 9:01am

I concurr about the mixed parameter.

#13

Posted by walkah on July 16, 2005 at 12:55pm

let me weigh in +1 on the mixed parameter side ... let's get away from blowing up backwards compatibility unless it's justified and/or unavoidable for the sake of progress. please :)

#14

Posted by chx on July 17, 2005 at 6:07pm
AttachmentSizeStatusTest resultOperations
nodeload.patch15.46 KBIgnored: Check issue status.NoneNone

#15

Posted by chx on July 17, 2005 at 6:17pm

poor book module remained unpatched.

AttachmentSizeStatusTest resultOperations
nodeload_0.patch18.98 KBIgnored: Check issue status.NoneNone

#16

Posted by chx on July 17, 2005 at 6:20pm

wrong version.

AttachmentSizeStatusTest resultOperations
nodeload_1.patch18.15 KBIgnored: Check issue status.NoneNone

#17

Posted by Stefan Nagtegaal on July 20, 2005 at 11:12am

I thought this had hit the trunk some days ago.. Chx, can you or Dries confirm and mark this issue as "Fixed"?

#18

Posted by Dries on July 20, 2005 at 11:31am
Status:needs review» fixed

This has been committed. Marking it 'fixed'.

#19

Posted by Anonymous on August 3, 2005 at 12:00pm

#20

Posted by Anonymous on August 17, 2005 at 12:00pm

#21

Posted by ax on August 31, 2005 at 5:10pm

#22

Posted by Anonymous on September 14, 2005 at 10:00pm

#23

Posted by Anonymous on September 28, 2005 at 10:01pm

#24

Posted by Anonymous on October 12, 2005 at 10:20pm
Status:fixed» closed (fixed)
nobody click here