Do not store dumps for default site in a sub-directory

I agree. However, I think you are referring to the 'default' site in single-site setups.

So the solution would be to store all dumps for the default site directly in files/demo. Dumps for other sites should automatically be stored in a sub-directory. Thus, no need for an option, and more importantly, no chance for users to configure this wrong.

Not really sure what you mean. I know the standard drupal install wants to put all files in drupal-root/files, but that's not very handy for multisite setups (like I run), and I believe most multisite developers put the files in drupal-root/sites/site-dir/files (at least I do). So having Demo automatically append the site folder name is redundant, e.g. drupal-root/sites/site-dir/files/site-dir. In addition, I don't even put my snapshots in the files folder, I put them in drupal-root/sites/site-dir/snapshots (though I get the sensibility of defaulting to a path Drupal can write to).

I'm not so sure my patch is the best approach. I do feel that things should not be done automatically, without the ability to override the behavior. Just my two cents.

If there are better ideas out there I'm willing to have a go at implementing them. If there is no interest in changing this behavior, I'll just have to live with it and roll my own patch for every update.

In any case it's a great module. I've already been using it heavily as a part of my development process. Whatever the conclusion, thanks for the work you've put into producing a really useful tool. Now to have a go at including files in the snapshot... :-)

I see. Actually, I'm not using different file paths for multi-site setups currently. Of course, using ./sites/<site>/files/ is legitimate, too.

In #1 I was referring to the unnecessary sub-folder in single-site setups: For the default site, demo creates a snapshot path ./files/demo/default/, which could simply be ./files/demo/ for the default site, but ./files/demo/<site>/ for any other site.

To complete this, we should check whether file_directory_path contains the site name already. If it does, Demo should not append the site name to the snapshot path. Additionally, Demo should not append the site name, if the site name is default.

Couldn't we just check whether the files path starts with site/<site>, and not append <site> if that's the case? Adding a configuration option seems overkill to me, and most likely of no value for 98% of our users.

Thanks for the great module. I find it however a bit counterintuitive to store the database dump in a subfolder while you explicitly state in which folder the dump should be stored. I would like to use the module in an installation profile with a dump file stored in a certain location, and the fact I cannot refer to that certain file is a bit limiting.

I aggree with smk-ka.

simply change

- sites/default/files/demo/default/file_name.sql

- sites/foo.com/files/demo/foo.com/file_name.sql

- sites/bar.com/files/demo/bar.com/file_name.sql

into

- sites/default/files/demo/file_name.sql

- sites/foo.com/files/demo/file_name.sql

- sites/bar.com/files/demo/file_name.sql

why get any messier? ;)

Implemented what luco said ;)
Please test the update process and creating dumps still works.

I've tested this, added another test to also avoid a site name sub-directory in case of 'sites/all/files' being the file directory path, works, and committed to 6.x and 7.x.

Good job. This ensures that people upgrading from 5.x, who most probably can't change their file directory path easily, will still have the site name in the path.

That said, exactly that last bit did not work, since the wrong path was being tested. Committed attached patch.

Automatically closed -- issue fixed for 2 weeks with no activity.