Just downloaded code base from May8th. In IE I am getting Javascript errors. I first get a error that there is a long running javascipt.

Not sure if this is a different issue but when I add a node type which the vocabulary applies to and submit the form, the selection is not saved. This behavior is reproducable in both FF and IE. In addition, if I disable the hierarchial select module, the saving of the new node type works as expected.

Comments

wim leers’s picture

Assigned: Unassigned » wim leers

Which version of IE?

32940stf’s picture

ie6

wim leers’s picture

Status: Active » Postponed (maintainer needs more info)

Well, I can't produce any error. Please provide the steps to reproduce this.

wim leers’s picture

Title: Java Script Error » Javascript error in IE
32940stf’s picture

I am getting the error when I open the "Edit vocabulary" page. The actual create page for a node works fine. So I imagine it has to do with the preview functionality.

32940stf’s picture

I just tried the May11 build and the problem still persists.

wim leers’s picture

Sorry, still can't reproduce. I think you need to tell me what your exact settings are… The easiest way to do that, is by looking at the variable table and sending me the value of the hierarchical_select_config_taxonomy-1 entry.

32940stf’s picture

Here you go:

a:5:{s:9:"config_id";s:10:"taxonomy-1";s:12:"save_lineage";i:0;s:15:"enforce_deepest";i:0;s:12:"level_labels";a:2:{s:6:"status";i:0;s:6:"labels";a:1:{i:0;s:0:"";}}s:7:"dropbox";a:3:{s:6:"status";i:0;s:5:"title";i:0;s:5:"limit";i:0;}}

wim leers’s picture

Nope, still can't reproduce.

Unless you have (or put) this site live, I'm afraid I won't be able to help you.

pingers’s picture

I have the same issue and may be able to make the site live within the week... if it's not fixed by then :)

wim leers’s picture

Ok.

I'm really curious what the cause of this is, because with these *exact* settings, I can't reproduce it… very odd!

32940stf’s picture

I am currently travelling on business. When I get home I should be able to get it up to a box as well. It will be a Windows box. What type of access do you need?

wim leers’s picture

Initially, just access to the Drupal web site. If that doesn't give me enough information, I will need FTP or SSH (preferred) access as well.

NeuZeitgeist’s picture

I have the same note in IE7. When I try to add a new document having Hierarhical select I have the same note. I do "No" and continue to work, but in any case it is not very convinient.
Thank you for the useful module :)

summit’s picture

Hi Wim,

I have the same issue. See attached picture. It is on IE6 with the latest .dev HS 3.
Settings are just installing HS3 and trying to update a vocabulary with it by using content/taxonomy/add/vocabulary
Hope this helps.

greetings,
Martijn

wim leers’s picture

NeuZeitgeist & Summit: could you please provide your exact configuration? It'd be interesting if it's the same as 32940stf's. And if it's different, I might be able to reproduce it here.

NeuZeitgeist’s picture

I have the same note as Summit and 32940stf's. What configuration you want to know? I use Hierarchical Select 5.x-2.2.

wim leers’s picture

See #7 for an explanation of what I need.

NeuZeitgeist’s picture

May be it is a problem of Jquery update? I changed it today and I have no this note in my IE7.

wim leers’s picture

You have to use jQuery Update 1.x, not 2.x. So it *might* be the cause.

summit’s picture

Hi Wim,

In /misc I have got JQuery 1.1.2. What further configuration are you looking for please?

greetings,
Martijn

wim leers’s picture

Summit: see #7.

summit’s picture

Variable: hs_config_taxonomy-

a:7:{s:9:"config_id";s:9:"taxonomy-";s:12:"save_lineage";s:1:"0";s:15:"enforce_deepest";s:1:"0";s:10:"node_count";s:1:"0";s:12:"level_labels";a:2:{s:6:"status";i:0;s:6:"labels";a:1:{i:0;s:0:"";}}s:7:"dropbox";a:3:{s:6:"status";i:0;s:5:"title";s:0:"";s:5:"limit";s:0:"";}s:11:"editability";a:4:{s:6:"status";i:1;s:10:"item_types";a:1:{i:0;s:0:"";}s:16:"allow_new_levels";i:1;s:10:"max_levels";s:0:"";}}

greetings,
Martijn

summit’s picture

Is this what your looking for Wim?
Thanks for going into this!
Greetings,
Martijn

wim leers’s picture

It seems something went wrong there: you have "hs_config_taxonomy-" as the config id, but it really should be "hs_config_taxonomy-", i.e. the vocabulary id is missing. Are you sure there's no other such variable?

Can you please go to that vocabulary's configuration form and hit the "Save" button and then test again? And please verify that a proper entry in the variable table exists then (i.e. one like "hs_config_taxonomy-1").

NeuZeitgeist’s picture

I run update.php as you told, but still I have no hierarchical_select_config_taxonomy in my table varible...

wim leers’s picture

I'm writing functionality to export configurations right now. Let's wait until that's committed, then retrieving this information becomes super easy.

32940stf’s picture

Wim,

I have set up a dev box which the behaviour is reproducable (it is a bit ugly right now so please forgive the cosmetics). I will sent to you directly the details. If you go into the categories and edit the "Where in the World" vocabulary, you should see the same behavior in IE6.

32940stf’s picture

BTW, it is the HS build as of May18th.

wim leers’s picture

Category: support » bug
Priority: Normal » Critical
Status: Postponed (maintainer needs more info) » Active

Thank you very much, 32940stf! You've helped me track down the cause. :)

This problem only occurs if you have the jQuery Interface module installed. So either I have some JS somewhere on that config page that is conflicting, or I'm using it in such a way that I'm triggering a bug.

For a quick solution: just uninstall the jQuery Interface module. You no longer need it for Hierarchical Select – you might need it for other modules, but that's unlikely.

wim leers’s picture

Confirmed: when I clear out common_config_form.js, it works. So it's somewhere in that file.

wim leers’s picture

The problematic code is:

cfg.context = function(configId) {
  if (configId === undefined) {
    return $('.hierarchical-select-config-form');
  }
  else {
    return $('#hierarchical-select-config-form-'+ configId);
  }
};

I don't know *why* this is so problematic though. Especially because it only happens in IE, and even then only when jQuery Interface is installed.

32940stf’s picture

Confirmed, removing the jQuery Interface module resolved the issue.

Thanks again Wim

wim leers’s picture

I found a work-around…

Changing
var configId = Drupal.settings.HierarchicalSelect.configForm[id];
to
var configId = Drupal.settings.HierarchicalSelect.configForm.id;
fixes the problem. It's all in the details, right? Sigh!

summit’s picture

Title: Javascript error in IE » Javascript makes IE freeze
Status: Active » Fixed

Hi Wim,
You mean deleting the sentence:

var configId = Drupal.settings.HierarchicalSelect.configForm[id];

?
greetings,
Martijn

wim leers’s picture

I fixed the typo above. Now you can see what it should be changed to.

summit’s picture

Hi,
the above .js change is in common_config_form.js in the /include folder.
greetings,
Martijn

wim leers’s picture

Indeed, as mentioned in #31. Note that I only posted this to indicate how minor the change was: this *is* fixed in the current tarball ;)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.