My use case in this patch is used for propagation of members along the groups’ hierarchy. I need to escape the hook along the propagation process.

CommentFileSizeAuthor
og_extend_args_1.patch2.32 KBamitaibu

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Needs work

Why can't modules use $args with the current code? Thats not passed along for the delete operation but the others look OK.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

With current code everything that's in the $args might be used in the
db_query('INSERT INTO {og_uid} ('. implode(', ', $fields). ') VALUES (%d, %d, %d, %d, '. implode(', ', $s). ')', $values);

Thus the code change also in 'insert'.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Fixed

committed to 5 ... would not apply cleanly to 6. the right fix for 6 is to not write own SQL and instead switch to using drupal_write_record()

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.