Request for Twitter link

I added a code for integrate Twitter in Service Links module.
If that's usefull for the project i can publish the patch. :))

I think that it makes sense to have in this case. It's useful when sites have a link to easily twitter a page or post.

Well my patch was for 5.x-1.1 version but i worked over the 6.x-1.x-dev too.

In the 5.x-1.1 patch i integrated the fix for technorati link found in dev version and added the modify for open into a new page the links through target="_blank" attribute.

For complete the new feature, twitter.png must share the same folder of the others images available.

I tried the 6.x patch and it looks good. The tinyurl integration is a nice touch, but maybe it should be optional or at least cache the results since a call to tinyurl.com on every non-cached page view may not work for everyone.

Either way +1 for this feature and patch.

@ronan, thank you for your review

i think the check code for considerate tinyurl result must be enough for discard the null (especially when free host service block this kind of task), do you think caching can be useful for increase the general performances?
Anyway im refactoring this project and i can provide too this feature as optional; before introducing the cache just for it lets lay down a new version.

Let me know if you have other hints for this project :))

Patch in #4 applied on a production website and it works fine. Thanks.

@toemaz Thank you for review,

This patch is also applied in the current 5.x and 6.x development branch (5.x-1.x-dev, 6.x-1.x-dev) :))

How can I install the patch for using twitter on service links?? is there any readme file or manual to help out??

Regards + thanks

This service is already into 1.x branch...

Thanks for that, it works like a charm! They should release a new version including the twitter icon.