Refactoring Service Links

I didn't yet mentioned it but i found the interestling patch by bdragon at http://drupal.org/node/185642 i wish integrate it...
Instead of service.inc, will have other modules with just the address of services, respecting in this way the Drupal extension philosophy :P

Definitely seems like a good place for DRUPAL-6--2 ;-) .

yes Rob, all these changes are for the new 2.x branch, and plus after your contrib about Yahoo Buzz i tought to speed the work changing the original plan; below all the news:

1. [OK] Adding the services will be really fast: put the image under images/ folder of service_links module) create a module implementing the hook_service_links() and returning an array like this:
   
   $links['my_service'] = array(
  'name' => 'MyService',
  'description' => t('Bookmark the post on MyService now!'),
  'link' => 'http://myservice.com/?q=<encoded-url>&title=<encoded-title>',
  'icon' => 'optional_just_if_the_icon_name_is_not_my_service_png.gif',
  'javascript' => 'my_javascript.js',
);
...

   well the icon field is optional =))

2. [OK] settings page will have the related icon in the service list;
3. [OK] service sorting through weights for 5.x branch
4. [OK] visual service sorting for 6.x branch (#365803: Change the order of icons);
5. [OK] support for short-link globally: for all the services, just for Twitter and similar (introducing a tag); for no one (#408618: Twitter TinyURL);
6. [Initial Phase as Tab] support for Share module;
7. [OK] support for Forward;
8. [OK] support for browser bookmarking;
9. [OK (Applied for a block)] Fisheye effect;
10. [Code under review for decide the best way] Indipendent popup effect;
11. [Code under review for decide the best way] Tag Extension;
12. [Code under review for decide the best way] CSS model instead of classical with IMG tag;
13. [Code under review for decide the best way] bookmark count with statistics page.

Some details:

1. About the default services i wish separate them from the core providing another folder (services/) and adding a module that implement hook_service_links() (general_services.module...) all the images will be stored under the original images/ folder too with a prefix (except for general, the other services can have some locale code prefix: it_oknotizie, ru_ruspace, ...); this way ensure a fast mode to learn about "expanding service links";
2. next i wish add many services from around the world, grouped for region or spoken lang for dont overload the general_service.module with 'less' used services (asian_services.module, italian_services.module, spanish_services.module...), this will be more a community work :))
3. all the module related to service links will be in the same 'service links' group (.info file);
4. i see many request related to changes over services__links_render()... for keep the main module thin i would like extend this process using another hook for alterate the params needed (hook_alter_services) and separate from it the function that require to scan the array of services.

Part of these features are already implemented in the 6.x branch available for download;
Thank you to all people partecipated actively or shared their ideas :))

The refactoring process is still open!

We needed a link to the forward module and a 'bookmark this' link

For the forward module it's pretty easy (I copied their icon to the image directory)

For the 'bookmark this' it's a bit more complicated, since there's no support for a class on a link (idea: pass a unique identifier to the theme function and a a class like service_link_uniqueid to each link). We ended up doing this

create a servicelink.js file and add it to your theme.info file

Great ideas attiks, i'll support both; for the second maybe i'll integrate Bookmark US module just for don't duplicate the efforces :))

Thank you!

Initial Drupal 6 version of Share is available. Docs haven't yet been written for the new API but you can take a look at the share_plugin or sharethis_plugin and link_codes modules for examples of how to use the API. The _plugin modules are used to provide different methods of displaying different ways to share. To add a tab to the share_plugin, look at the link_codes module.

The Share API is not set in stone so any advice or needs please share.

Initial patch for Share version 2 can be found at #413860: Beginning work for implementation of Share hooks

Good idea integrating with bookmark, only 'problem' i see is that their icon is a bit bigger then yours, so it looks a bit weird.

@greenSkin great news, if i understood well your module now allow different profiles and for each tab module different settings can be configurated (as link_codes do)... if that's right ill need more time for integrate the whole system! Anyway thank you for the patch is a good start :)).

@attiks another problem with bookmark_us is the module allow the bookmark only for the current page and not the single post. Ill try to talk with the author for expand some feature otherwise ill bring service links in the hall of shame =))

It would be neat to have an option to mimic the fisheye effect shown here:
http://www.sociofluid.com/

...without having to link an external script like that service requires.

Hello,

I think it would be nice feature if this module kept track of what was being bookmarked.
so you could have a "most bookmarked" block.

great work.

You said this was in DRUPAL-6--2? I don't see it anywhere. I just see DRUPAL-6--1.....

Here is a proposal for a hook_service_links(). Since we don't really know if the service requires additional JavaScript, or CSS, we have a gathering hook and an adding hook that's called when a service is added.

So we end up with hook_service_links() and hook_service_links_add(). We could even easily add a hook_service_links_alter() ;-) .

@lpkb, @loze two pretty ideas i would like to add them as external addons but about the fisheye effect for have something good will need 128x128 icons, so i dont know if is better keep it as an example for theme extension.

@Rob before upload im fixing some detail and reviewing some point... wondering if the render function can accept a theme function as input (so we reuse the standard render function but with another theme job) but too if the render function can be variable and served as option... if we want integrate the bookmarks count i tought on a menu item as service_links/twitter/node-id (and relative callback function)... links will have an url in this path instead of the classic http://twitter.com/... so we can count the link and redirect at the service page after the validation... :))

[EDIT] 6.x-2.x Branch is officially in CVS and available for download in the project page!

I did a bunch of work with Service Links today and hit up a number of things in commit 250904.

Caching

The retrieval of all the service links is now cached for some speed improvement. Due to this, a hook_service_links_alter() could be introduced.

Callback function

The 'callback' function in hook_service_links is invoked when the service link is created. This allows any additional custom code to be run when processing the link.

Service specific CSS

Like 'javascript', we can now have a CSS file added when the service link is added to the page.

Documentation

I added a service_links.api.php which details hook_service_links and hook_service_links_alter.

Works nicer with other modules

Once this commit was in, it allowed the removal of the majority of the ShareThis module making the ShareThis 6.x-2.x branch depend on Service Links to stick the ShareThis button in the correct location. Check it out!

Regarding #10 in your todo list , I just made #548960: Use inline popup for Service Links.

I'm a big fan of your module and appreciate the work you all are putting in. Do you have any guesses about when you will release 6.x.2?

Following

following

The 2.x branch of the module *greatly* improves the functionality of the module, great work on it.

I have a few suggestions.
1. Service link should allow the user a choice to select the size of images. [perhaps a "Large Icons: Yes/No" check-box?]
2. Integration with the AddtoAny module.

hello,

i just installed the module and like it very much! i placed the servicelinks block in the right menu pane. when i select icons only it takes only 3 lines, but when you move the mouse over the icons you don´t get a popup which service it is. enabling icon + text makes a list where you must scroll down a long list - not what i want...

feature request: please add a mouseover effect for each icon so the service name is displayed when the cursor is over a icon. this would make it easier for people to find the correct social bookmark link.

thank you very much!

brgds Deas

following