First, thanks for this easy to use module! Maybe I've been using Drupal too much, but I'm always impressed when something works the way you expected and wanted it to work the first time you use it. That says something.

I was wondering if the text that goes with the collapsible link could be passed through the filter instead of in header tags within the text itself. as in [collapsible text=read more!] instead of [collapsible]<h1>read more!</h1>. It's not a huge deal for me, but I think it would allow more flexibility/usability/all around goodness.

Thanks for your time.

Anisa.

CommentFileSizeAuthor
#7 collapse_text_opt_title_patch.txt3.61 KBpukku

Comments

spiffyd’s picture

spiffyd commented
Category: feature » bug
Priority: Normal » Critical

The header does't show up. I get a link called "Interpretation" all the time even when I do this:

[collapse]<h1>LINK SHOULD BE CALLED THIS</h1> TEXT HERE [/collapse]

Bug? Anyone else get this?

iboekoe’s picture

iboekoe commented
AndrewLeon’s picture

AndrewLeon commented

Does anyone know if it's possible to center the title?

spiffyd’s picture

spiffyd commented

I think you can use CSS to do that... just start by viewing the HTML and seeing which class or id to target.

pukku’s picture

pukku commented
Version: 5.x-1.0 » 6.x-1.0
Assigned: Unassigned » pukku
Category: bug » feature
Priority: Critical » Normal
Status: Active » Closed (duplicate)

Hi! The original issue is a semi-duplicate of #233877: Attached is modified version including nesting and custom title support. spiffyd, if you're still having problems, please file a separate bug report so that tracking of your problem can be done properly.

pukku’s picture

pukku commented
Status: Closed (duplicate) » Active

I've redecided, and I'm going to fix this issue separately from #233877: Attached is modified version including nesting and custom title support.

pukku’s picture

pukku commented
Status: Active » Needs review
StatusFileSize
new collapse_text_opt_title_patch.txt3.61 KB

Patch attached.

pukku’s picture

pukku commented
Status: Needs review » Fixed

committed.

spiffyd’s picture

spiffyd commented

Is there any way to only make the

title text only show up as the link and not in the content header?

spiffyd’s picture

spiffyd commented

Nevermind, I figured it out... CSS is the solution.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Flying Drupalist’s picture

Flying Drupalist commented
Version: 6.x-1.0 » 6.x-1.1
Status: Closed (fixed) » Active

I'm using 1.1 and neither this:[collapsible text=read more!] nor this: [collapsible]
read more!

works. What's the correct way to do this?

spiffyd’s picture

spiffyd commented

see #1... you're doing it all wrong.

to start out collapsed go
[collapse collapsed]<h1>LINK SHOULD BE CALLED THIS</h1> TEXT HERE [/collapse]

Flying Drupalist’s picture

Flying Drupalist commented

Am I missing something? That doesn't work for me.

It just says: Use the arrow to expand or collapse this section.

and I see the this text: LINK SHOULD BE CALLED THIS TEXT HERE

Flying Drupalist’s picture

Flying Drupalist commented

@spiffyd, the correct way is like this, after checking out the module code:

[collapse collapsed title=LINK SHOULD BE CALLED THIS]TEXT HERE [/collapse]

Flying Drupalist’s picture

Flying Drupalist commented
Status: Active » Fixed
spiffyd’s picture

spiffyd commented

Hmm... @Miraploy, that's interesting...

You are correct.

However, I have been able to get it to work without the TITLE attribute by using H1 content as the title and using CSS to hide the H1. Now I no longer have to do this!

k3vin’s picture

k3vin commented

[collapse collapsed title=LINK SHOULD BE CALLED THIS]TEXT HERE [/collapse] should mention in the description and readme too.

I tried this before [collapse]<h1>LINK SHOULD BE CALLED THIS</h1> TEXT HERE [/collapse] and that doesn't work anymore.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.