put collapsible text link in the filter, not in header tags

rivena - May 17, 2008 - 07:37
Project:Collapsible Text
Version:6.x-1.1
Component:Code
Category:feature request
Priority:normal
Assigned:pukku
Status:closed
Description

First, thanks for this easy to use module! Maybe I've been using Drupal too much, but I'm always impressed when something works the way you expected and wanted it to work the first time you use it. That says something.

I was wondering if the text that goes with the collapsible link could be passed through the filter instead of in header tags within the text itself. as in [collapsible text=read more!] instead of [collapsible]<h1>read more!</h1>. It's not a huge deal for me, but I think it would allow more flexibility/usability/all around goodness.

Thanks for your time.

Anisa.

#1

spiffyd - October 25, 2008 - 10:47
Category:feature request» bug report
Priority:normal» critical

The header does't show up. I get a link called "Interpretation" all the time even when I do this:

[collapse]<h1>LINK SHOULD BE CALLED THIS</h1> TEXT HERE [/collapse]

Bug? Anyone else get this?

#2

iboekoe - October 31, 2008 - 20:14

#3

AndrewLeon - November 5, 2008 - 19:53

Does anyone know if it's possible to center the title?

#4

spiffyd - November 5, 2008 - 23:10

I think you can use CSS to do that... just start by viewing the HTML and seeing which class or id to target.

#5

pukku - December 15, 2008 - 15:04
Version:5.x-1.0» 6.x-1.0
Category:bug report» feature request
Priority:critical» normal
Assigned to:Anonymous» pukku
Status:active» duplicate

Hi! The original issue is a semi-duplicate of #233877: Attached is modified version including nesting and custom title support. spiffyd, if you're still having problems, please file a separate bug report so that tracking of your problem can be done properly.

#6

pukku - December 15, 2008 - 15:27
Status:duplicate» active

I've redecided, and I'm going to fix this issue separately from #233877: Attached is modified version including nesting and custom title support.

#7

pukku - December 15, 2008 - 15:46
Status:active» needs review

Patch attached.

AttachmentSize
collapse_text_opt_title_patch.txt 3.61 KB

#8

pukku - December 15, 2008 - 15:47
Status:needs review» fixed

committed.

#9

spiffyd - December 16, 2008 - 07:12

Is there any way to only make the

title text only show up as the link and not in the content header?

#10

spiffyd - December 16, 2008 - 08:46

Nevermind, I figured it out... CSS is the solution.

#11

System Message - December 30, 2008 - 08:50
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#12

Flying Drupalist - January 24, 2009 - 17:13
Version:6.x-1.0» 6.x-1.1
Status:closed» active

I'm using 1.1 and neither this:[collapsible text=read more!] nor this: [collapsible]

read more!

works. What's the correct way to do this?

#13

spiffyd - January 24, 2009 - 19:43

see #1... you're doing it all wrong.

to start out collapsed go

[collapse collapsed]<h1>LINK SHOULD BE CALLED THIS</h1> TEXT HERE [/collapse]

#14

Flying Drupalist - January 24, 2009 - 20:11

Am I missing something? That doesn't work for me.

It just says: Use the arrow to expand or collapse this section.

and I see the this text: LINK SHOULD BE CALLED THIS TEXT HERE

#15

Flying Drupalist - January 24, 2009 - 20:14

@spiffyd, the correct way is like this, after checking out the module code:

[collapse collapsed title=LINK SHOULD BE CALLED THIS]TEXT HERE [/collapse]

#16

Flying Drupalist - January 24, 2009 - 20:15
Status:active» fixed

#17

spiffyd - January 24, 2009 - 20:38

Hmm... @Miraploy, that's interesting...

You are correct.

However, I have been able to get it to work without the TITLE attribute by using H1 content as the title and using CSS to hide the H1. Now I no longer have to do this!

#18

bit7 - January 27, 2009 - 12:33

[collapse collapsed title=LINK SHOULD BE CALLED THIS]TEXT HERE [/collapse] should mention in the description and readme too.

I tried this before [collapse]<h1>LINK SHOULD BE CALLED THIS</h1> TEXT HERE [/collapse]  and that doesn't work anymore.

#19

System Message - February 10, 2009 - 12:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.