301 passes, 16 fails and 4 exceptions.
Failures:
Found the requested form [Other] Fail (poll)
Failed to set field choice[0][chtext] to simpletest_sA7q9w1j9_ANUXoD33zrjSOqBomTFwIX [Other] Fail
Failed to set field choice[1][chtext] to simpletest_L3wkT7OTg5iZC985rDthE5_hkcjWEBDR [Other] Fail
Node simpletest_lf24Pw_x was loaded at [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 268] [Other] Fail
Found the requested form [Other] Fail (trying to go to node/ 0.000000edit)
Found the Save button [Other] Fail
Failed to set field choice[0][chtext] to simpletest_uosWWAhsKrR9LYIh_huDioDYVLeOSjXA [Other] Fail
Failed to set field choice[1][chtext] to simpletest_Wo8GTeglKCUTNtqAUCZOmMJeKMcxhmzK [Other] Fail
HTTP response expected 200, actual 404 at [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 272] [Browser] Fail
Found the requested form [Other] Fail (trying to go to node/ 0.000000delete)
Found the Delete button [Other] Fail
HTTP response expected 200, actual 404 at [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 275] [Browser] Fail
HTTP response expected 404, actual 200 at [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 278] [Browser] Fail
DBLog event was recorded: [content added] at [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 291] [Other] Fail
DBLog event was recorded: [content updated] at [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 293] [Other] Fail
DBLog event was recorded: [content deleted] at [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 295] [Other] Fail
Exceptions:
Unexpected PHP error [Trying to get property of non-object] severity [E_NOTICE] in [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 271] [PHP] Exception
Unexpected PHP error [Trying to get property of non-object] severity [E_NOTICE] in [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 274] [PHP] Exception
Unexpected PHP error [Trying to get property of non-object] severity [E_NOTICE] in [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 277] [PHP] Exception
Unexpected PHP error [Trying to get property of non-object] severity [E_NOTICE] in [/Applications/MAMP/htdocs/head/modules/dblog/dblog.test line 307] [PHP] Exception
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | tests-260369-dblog-poll-fix.patch | 1.12 KB | damien tournoud |
| #2 | tests-260369-dblog-poll-fix.patch | 1.47 KB | damien tournoud |
Comments
Comment #1
boombatower commentedSee http://drupal.org/node/251225#comment-848930
Comment #2
damien tournoud commentedHere is a simple patch for that issue.
BUT: it turns out that there is an off-by one error between the choice id at insertion (which start at 0) and the choice id when updating (which start at 1). I can understand why (database ids start at 1), but it is certainly not good practice.
Comment #3
damien tournoud commentedSome debugging stuff got stuck in the pipeline. Here is a correct patch.
Comment #4
damien tournoud commentedHum. It's looks more bad that I though.
In Drupal 7, chid is now a serial shared by all poll form. It means that you have no way to know at insertion time the chid each choice will finally have (that means tests will break somewhere down the road).
Looking at the schema, it seems to make no sense (the natural primary key is more [nid, choice_id]). I will open a separate issue for that.
Comment #5
catchThis fixes the 16 failures in dblog.test, RTBC.
Comment #6
dries commentedI've committed this patch to CVS. When reviewing the dblog tests, it occurred to me that many of them might not make a ton of sense (in the context of dblog).
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.