Project:NodeReview
Version:6.x-1.0-alpha4
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi folks,
I created a patch that allows the admin to set the amount of votes to a number of his/her choice. Now, the maximum vote is "10", without any opportunity to change that.

I patched against HEAD, but in HEAD the nodereview.module doesn't seem to include the Fivestar-related code of v. 1.5.2.6.

cheers,
TUc

Comments

#1

#2

DRUPAL-5 is the currently maintained branch. HEAD is missing all the bug fixes and features I've added recently.

#3

Status:needs review» closed (won't fix)

This won't be fixed anymore or replicate to verify this issue, we just have to move forward and making version 6 stable and create version 7 dev.

#4

Version:master» 6.x-1.x-dev
Status:closed (won't fix)» active

This is still a valid feature request for later versions.

#5

Hi Crell,

Isn't 10 enough to rate a content, or can we really allow users to type in the maximum value.
I am just thinking of a field multiplier input, like if you have 1 to 10 ratings, add a multiplier of 10, so this gives you 10, 20, ... to 100, a multiplier of 20 gives you 20, 40... to 200

What do you think?

#6

Following this idea, it avoids seeing like 100, 200 or more stars

#7

Status:active» needs review

I just made the maximum to 10, admin can set this just like the fivestar number of stars

#8

Status:needs review» active

That's an interesting question. Limiting it to 10 steps and then including a multiplier is one option, but that means you cannot do, say, a 20-step review scale. I don't know if we want to make that fully variable or not.

Input from people using this module would be good. :-)

As in the other issue, this isn't "needs review" if there's no patch.

#9

Got it, so probably I can just set the maximum scale steps to 100, nobody probably would have a 80.25, 80.5 or 80.75 on their review scale.

1) I think this can only be for the numeric, like 8/10 or 85/100
2) For the Label ratings, having more than 10 is a crazy idea, like:

  1. Forget it
  2. Bad
  3. Not Bad
  4. Ordinary
  5. Good
  6. You can do better
  7. Better
  8. Best
  9. Excellent
  10. Outstanding

3) For the fivestars, we are already violating the idea of fivestars for have more than 5 stars, or can we name it 10 stars, :D

What do others think?

#10

just reading this now... the problem with the scale in fivestar is voting api equates them to a scale of 100 for percentages. so for a 5 point scale, 1 star is recorded as 20 in the votingapi tables. If a user has a 7 point scale, that will create some funky results for fivestar + votingapi. It's part of the issue identified here: http://drupal.org/node/260666

#11

Version:6.x-1.x-dev» 6.x-1.0-alpha4

Users can now put their custom maximum rating, from 1 to 100.

#12

Status:active» fixed

#13

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.