Closed (fixed)
Project:
Fivestar
Version:
5.x-1.13
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 May 2008 at 03:24 UTC
Updated:
19 Oct 2008 at 22:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
quicksketchYou'll need to upgrade to the latest version of Fivestar to see if this is still a bug in the latest release. It should delete only that single anonymous vote, as per this query from Fivestar:
Comment #2
xqi commentedquicksketch, thanks for the reply.
I am using the latest release of fivestar and votingapi.
i think the deletion happens in the following code when calling votingapi function votingapi_unset_vote. which really should pass the hostname as a parameter. it seems to me votingapi and fivestar need collaborate to have this bug fixed.
'. $item['target']);
}
if (is_numeric($items[$delta]['target'])) {
votingapi_unset_vote('node', $items[$delta]['target'], $node->uid);
}
}
?>
Comment #3
quicksketchThe code you pointed out is from the Fivestar CCK implementation, I was assuming you were using normal comments. Are you indeed using CCK for your reviews? That'd help me understand where this problem is located.
Comment #4
xqi commentedyes, i use fivestar as a cck field in my node type "review".
Comment #5
xqi commentedbump
Comment #6
quicksketchI finally got to looking at this problem, it's Drupal 5 specific as VotingAPI in Drupal 6 handles this logic for us. Fivestar was only adding the hostname to the queue when a $uid was not being passed in. However, in the case of node-based reviews, the UID was always being passed in, since the UID is not the current user, but the UID of the node author. This patch should fix the problem, and I've already committed it.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.