should photoset filter show a photoset?
docwilmot - May 25, 2008 - 19:37
| Project: | Flickr |
| Version: | 6.x-1.0-beta4 |
| Component: | flickr (main module) |
| Category: | feature request |
| Priority: | critical |
| Assigned: | paulbooker |
| Status: | active |
Description
i assumed that adding a photoset filter would show a photoset (several thumbs) on my drupal site, but i am just getting one thumb which links to my flickr site. is that the expected behavior?
#1
Same question here.
#2
+1 ;-)
i have the same question.
because i don't really see the point in using flicker-photoset tag when i can just link to the photoset
#3
Hello,
I wanted to ask whether or not flickr photosets are supposed to embed the whole gallery in Drupal, or just the first photo with a link to the gallery.
If not, do you know of a way to embed a whole gallery? That's what I'm really looking to do.
Great module, thanks for maintaining it and developing it.
Thanks,
Jeremy
#4
See the flickr_sets module
#5
#4 - andrewlevine response is not relevant. This desired functionality is not in the module.
I like others want this functionality and there is a feature request, started a long time, with several patches that haven't been applied. I'm trying to sort through it today to see if any of the patches are usable:
http://drupal.org/node/152792
Shai
#6
I'd like this too. Meanwhile, I'm using functionality from Flickr Slideshow Generator at http://fabiocavassini.com.ar/SlideShowGenerator.html to generate these slides. It surprises me that there isn't support for this in a filter already.
#7
Getting the same thing in the 6x-1 Alpha1 version.
I have the blocks working, just not the sets thing.
#8
Hi,
the problem may rely in flickr_filter.
At the end of
filter/flickr_filter.modulewe have<?phpfunction theme_flickr_filter_photoset($ps, $owner, $size, $attribs) {
return theme('flickr_photoset', $ps, $owner, $size, $attribs);
}
?>
and in
flickr.module:<?phpfunction theme_flickr_photoset($ps, $owner, $size, $attribs = NULL) {
$img = flickr_img($ps, $size, $attribs);
$photo_url = flickr_photoset_page_url($owner, $ps['id']);
$title = is_array($ps['title']) ? $ps['title']['_content'] : $ps['title'];
return l($img, $photo_url, array('attributes' => array('title' => $title), 'absolute' => TRUE, 'html' => TRUE));
}
?>
So the functions in
sets/aren't used at all when using the[flickr-photoset:...]filter.Can we change that please?
I'll try myself, but I don't know drupal very well yet, so it might take time.
Thanks,
Antonio
#9
Hi,
I found a solution that *works for me* (TM) :)
This now becomes a feature request.
Attaching the patch here. The code duplicates what's also in
sets/flickr_sets.module.Thanks,
Antonio
#10
Any updates on this?
The above patch doesn't work for me since I'm on 5 I guess.
#11
Very sorry, but I dont know how to use a patch.
can you please make a tarball of all the files after your patch and attach here?
Thank you very much
#12
@bgogoi: http://drupal.org/patch
#13
so easy! Thanks Andrew :)
#14
Does the patch re #9 work for people then. It doesn't make any difference for me (5.x).
#15
This patch works for me, except "size" feature - clicking on image always gives link to "medium" size flickr image. Does "size" works for you?
#16
hi naiptol,
can you test the new attached version?
It contains this change:
--- flickr-expand_photoset_rendering.patch 2008-10-14 19:32:07.000000000 +0200+++ flickr-expand_photoset_rendering_v2.patch 2008-10-14 19:32:06.000000000 +0200
@@ -25,7 +25,7 @@ diff -bruN flickr.orig/flickr.module fli
+ foreach ((array) $photos['photoset']['photo'] as $photo) {
+ //insert owner into $photo because theme_flickr_photo needs it
+ $photo['owner'] = $owner;
-+ $output .= theme('flickr_photo', $photo, 's');
++ $output .= theme('flickr_photo', $photo, $size);
+ }
+ $output .= '</div>';
+ $output .= theme('pager', NULL, variable_get('flickr_photos_per_page', 20));
#17
Hi, ao2,
Thank you for patches! :)
You can see test results in http://eminute.net/en/flickr_test
Drupal 6.5 , Lightbox2 6.x-1.8, flickr module 6.x-1.x-dev (2008-Sep-30) flickr-expand_photoset_rendering_v2.patch.
(I will upgrade versions in the future, so this is current moment)
There is the same flickr photoset with diferent sizes in filter. In previous patch version (flickr-expand_photoset_rendering_v1.patch) all of them looked like with 'size=s'. Now sizes are different.
Only one moment. There are 2 sizes actually. One is "what sizes you see in page showing all photoset", and another is "what size image you get when you click one of them".
Currently when I click on picture in photoset, I get 'medium' sized image with s, t, m, -, and 'original' with b, o. (my original pictures are 800px on longest size).
I think 'original' would be better, than 'medium', becouse 'medium' is too small, and if 'original' is too large, it is possible to manage this with Lightbox2 settings.
Also one strange effect:
I set 'Continuous Galleries' in Lightbox2, and when I watch the same gallery 2-nd time, looks like I get 'Original' size, except last image in gallery, which shows 'broken image', if I go further, 3-d time I get 'medium' again, 4-d - "original', except last image, and so on. It looks like bug somewhere.
#18
I noticed in the code you can change how many pictures per page to display for the paging feature. Unfortunately when I load an album with more than the said amount of photos, no pagers show up. It only displays the default number of photos you have set in the code (20). You can change this to allow for more but I have albums with 50+ pictures that I didnt want to load on one page alone. Any thoughts on how to get the paging to work?
#19
Great job everyone! Works fine.
Needed to add the 'type' field to the flickr_set.module which may be a issue that is looked at further down the issue queue.
$items['flickr/%user/sets/%flickr_set'] = array('title' => 'Flickr photo set',
'page callback' => 'flickr_sets_photoset',
'page arguments' => array(1, 3),
'type' => MENU_DEFAULT_LOCAL_TASK,
);
Ill get this committed to the development branch later today
#20
#21
Ok. So, I noticed that there is a flickr-photoset class div wrapped around the images. I thought that I would simply put a margin around the images using CSS to get some space between them. However, I was having trouble getting it to recognize my CSS changes. I couldn't figure out why it wasn't working. Turns out that the div class is misspelled. It actually says "fickr-photoset". This should be corrected before committing it to the dev branch.
#22
Right now I'm using Flickr 6.x-1.0-beta4.
The problem that only one picture is being displayed in photosets on a page or in articles persists?
Are there any progresses?
#23
#24
Sorry for my last blank reply.
I've made a patch for flickr.admin.inc that enables more than 20 photos of a photoset in every node created with patched flickr.module thanks to ao2 (#16).
Both work well.
#25
Instead of duplicating code in flickr.module, I have done the following in flickr_filter.module
function theme_flickr_filter_photoset($ps, $owner, $size, $attribs) {//return theme('flickr_photoset', $ps, $owner, $size, $attribs);
// jonga
$photo_arr = flickr_set_load($ps['id']);
$set_info['owner'] = $owner;
$set_info['size'] = $size;
return theme('flickr_sets_photoset', $uid, $per_page, $photo_arr, $set_info);
}
And also in flickr_sets.module
function theme_flickr_sets_photoset($uid, $per_page, $photo_arr, $set_info) {$output =
theme('pager', NULL, variable_get('flickr_photos_per_page', 20));
$output .= "<div class='fickr-photoset'>\n";
foreach ((array) $photo_arr['photoset']['photo'] as $photo) {
//insert owner into $photo because theme_flickr_photo_box/flickr_photo_page_url needs it
$photo['owner'] = $set_info['owner'];
//$output .= theme('flickr_photo_box', $photo, 'm');
// jonga
$output .= theme('flickr_photo_box', $photo, $set_info['size']);
}
$output .= '</div>';
$output .=
theme('pager', NULL, variable_get('flickr_photos_per_page', 20));
return $output;
}
code after // jonga is added
#26
Limited time.
I have implemented these patches so that if you don't have the flickr_sets module enabled and a node is rendered showing a photoset filter it will just shows one image from the photoset but if you have the flickr_sets module enabled it will show all the photoset images . However i have taken out the pager on the photoset as it doesn't work and i don't want to get sidetracked fixing this .
I'll commit to the development branch later today . Please provide feedback.
Thanks for all you help.
Best, Paul
#27
#28
#29
Automatically closed -- issue fixed for 2 weeks with no activity.
#30
Is this committed? I have the latest dev version of the module, but I only see one image from my photoset in my node after inputting the photoset code in the Flickr CCK field.
#31
I'm not sure this is actually fixed. I'm having difficultly getting a photo set to display - like others in the comments before me, all I'm seeing is a single photo from the photoset.
Here's what I have:
1. Modules enabled: Flickrfield, Flickr, Flickr Sets (dev version from 2009-June-24).
2. I added a "Flickr Photo" field to the "blog" content type with all the default settings.
3. I created a new blog post and in the Flickr fieldset, I set:
- Item Type: photoset
- ID: 72157622689719750
- User ID: MichaelFlickr
(enjoy the photos of my kids!)
Upon viewing the node, I don't see the entire photoset, just the first photo from the set. The "Source: Flickr" link below the photo links to the photoset.
What am I missing in order to pull in all the images from the photoset?
Thanks in advance,
-mike
#32
Just figured out what I was doing wrong - hopefully this will help save somebody else some time...
There are 2 types of CCK fields included with the FlickrField module - "Flickr Photo" and "Flickr photo set". If you want to be able to display an entire set in a node, you need to choose the "Flickr photo set" type (obviously). I was banging my head against the wall because I inherited a site with the wrong type selected from the start.
-mike
#33
changing issue title back - @ultimike Thanks for helping people with your comment. However, note when you change the "Issue title" field it changes for the whole issue, not just your comment.