Now, using Internationalization module CSS classes for sections are taken from language prefix, instead from real path. This patch solve the issue using _i18n_get_original_path() function.
Maybe the same control statement could be used to add a new CSS class for language (e.g. "lang-en") using the i18n_get_lang() function. This will provide a backward compatibility for those are still using classes like section-en for their pages.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | patch2.txt | 906 bytes | poiu |
| #1 | patch.txt | 849 bytes | poiu |
| zen_i18n_sections.patch | 650 bytes | chirale |
Comments
Comment #1
poiu commentedThis patch fails for me if there's a lang prefix in the path. _i18n_get_original_path() returns the path with the prefix. I had to strip it off with i18n_get_lang_prefix.
I also added a
'lang-'. i18n_get_lang()class.Note: this *will* break sites relying on the old, buggy behaviour (i.e. the section-en class).
Comment #2
poiu commentedforgot to change status...
Comment #3
poiu commentedSlight problem, the lang-XX class won't be added to the front page if it's inside the !is_front conditional block. Moved it out.
Comment #4
johnalbinPoiu, yeah, breaking existing sites is a no-go. Actually we could prevent breakage by providing: .section-LANG, .lang-LANG, and .section-CORRECTED-SECTION. i.e. we provide the old-style i18n-uncorrected section class along with the new ones.
Can you re-roll?
Also, I would love something for 6.x-1.x. But from a glance at i18n 6.x, it looks like the API has changed. Can someone let me know the 6.x equivalent to the i18n functions used in this patch?
Comment #5
johnalbinWhoops. Pre-maturely bumped version. Need patches for both versions, really.
Comment #6
johnalbin