Missing argument 2 for date_formatter_process

See #264208: Delimiter must not be alphanumeric or backslash for that error.

Changing title so we can focus on the date_formatter_process error messages.

I'm also getting the errors for Missing argument 3 for date_formatter_process() and Missing argument 3 for date_formatter_process()

On line 41 of date.theme we find $dates = date_formatter_process($element);

The problem is that the function defining date_formatter_process() found on line 115 of date.module looks like this:
function date_formatter_process($field, $item, $node, $formatter = 'default')

This function needs 3 arguments, and is only getting the one $element. I don't know where $element is coming from...

I didn't look at this very long, so I could way off, but the attached patch simply takes the arguments being given to function theme_date_display_combination($field, $item, $dates, $node = NULL)

and passes them to the the date_formatter_process(), like this:

-  $dates = date_formatter_process($element);
+  $dates = date_formatter_process($field, $item, $node);

Actually, the only place theme('date_display_combination', …) is called is from date_field_formatter():

  // Call the right theme for this formatter.
  $dates = date_formatter_process($field, $item, $node, $formatter);
  if ($formatter != 'format_interval') {
    $output = theme('date_display_combination', $field, $item, $dates, $node);
  }

So actually date_formatter_process() is already run before theme_date_display_combination() is called. And since $formatter is not passed to the theme function, we can’t call pass $formatter to date_formatter_process() from within the theme function. So not only is the date_formatter_process() not needed in the theme function, you can't even call it correctly from within the theme function.

This patch simply removes that line from theme_date_display_combination() since its both redundant and broken.

Patch #4 applies cleanly, and the errors are gone!
Thanks John.

Thanks! This is committed.

This sneaked back in there with this commit http://drupal.org/cvs?commit=119505.

Attached is a reroll of JohnAlbin's patch against the latest dev.

Good catch, Noah!

Thanks -- trying to work on several versions at once is a recipe for disaster :)

Fix re-committed.