I noticed when I subscribed and didn't confirmed it, I can't subscribe again. If I do subscribe again I get this email telling me that I was already in the list. So if I delete the email where my confirmation code is stored, there's no way I can get into the list.

I think the problem is in this line of the _block hook:
$snid_result = db_query("SELECT s.snid FROM {sn_subscriptions} s WHERE s.mail = '%s', $sn_email);

I think there should be another condition added, "AND s.a_status=1".

I'm sorry if I can't file a patch..

Comments

DriesK’s picture

DriesK commented
Assigned: Unassigned » DriesK

Thanks for the notification. Except from an extra condition, some extra logic has to be adjusted as well. I'll take a look at it tonight.

dries’s picture

dries commented

You can probably make it so users can subscribe, even though they are already subscribed. However, make sure the e-mail address isn't duplicated in the database. Just deal with it silently, and let the user be happy. It might be possible to solve this by taking out some logic, rather than adding some.

DriesK’s picture

DriesK commented
Status: Active » Fixed

Fixed as suggested by Dries: anonymous users can always subscribe, irrespective of subscription status.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
DriesK’s picture

DriesK commented
Version: » 7.x-1.x-dev
Status: Fixed » Closed (fixed)

Closed because the automatic close feature in project module is broken, and the issue list is becoming cluttered.