sorry if I missed this somewhere, but is support planned?

Thanks. This is a great module.

CommentFileSizeAuthor
#11 fixes_on_port.patch3.32 KBswentel
#4 troll6.zip15.96 KBjvandyk
#2 troll6jv.patch94.93 KBjvandyk
#2 troll.zip15.99 KBjvandyk

Comments

jaydub’s picture

jaydub commented

It's a ways off I'm afraid. There are a number
of things I am working on in the 5.x version and
in reality my day job and work on other modules is
taking time from troll as well...

jvandyk’s picture

jvandyk commented
Status: Active » Needs review
StatusFileSize
new troll.zip15.99 KB
new troll6jv.patch94.93 KB

I've ported the module to Drupal 6. Patch is attached. Forms now use FAPI instead of Drupal 4-6-style controllers. Actions that emanate from links now have confirmation forms to avoid CSRF attacks. I split the module into troll.module and troll.admin.inc.

The patch was made against the DRUPAL-5 branch at deekayen's recommendation.

I'm also attaching a .zip for convenience.

deekayen’s picture

deekayen commented
Status: Needs review » Needs work

Coder minor level analysis is throwing several notices about spaces and @see. Resolve those, and I'll commit (unless jaydub objects before I get to it).

jvandyk’s picture

jvandyk commented
Status: Needs work » Needs review
StatusFileSize
new troll6.zip15.96 KB

For backport.

Babalu’s picture

Babalu commented
Status: Needs review » Needs work

subscribing

deekayen’s picture

deekayen commented
Assigned: Unassigned » deekayen
Status: Needs work » Postponed

I'm working through this patch with jvandyk in IRC right now.

fuzzy_texan’s picture

fuzzy_texan commented

subscribing

TSNetwork’s picture

TSNetwork commented

Any progress?

noctifer’s picture

noctifer commented

subscribing

swentel’s picture

swentel commented

Subscribing.
One request I'd like to see: move admin/settings/troll* to admin/user/troll. Core access rules are also there, makes more sense to me in a way.

swentel’s picture

swentel commented
StatusFileSize
new fixes_on_port.patch3.32 KB

There are some errors in the D6 port in #4. Patch fixes that + a feature request, namely possibility to change the expire date on the confirm form when banning an ip.

coreyp_1’s picture

coreyp_1 commented

is there anything we can do to help this process along?

coreyp_1’s picture

coreyp_1 commented

Let me re-state my question:

I just finished helping to port the Spam module to D6, and I think that this module would be great to have in D6 as well.

Is there a patch in development, or should we start anew? Should we be using 5.x-1.3 or 5.x-1.x-dev?

hba’s picture

hba commented

Is there any development code in cvs that is usable?

stuartduff’s picture

stuartduff commented

Any further indications if there is going to be a Drupal 6 version for this module as it is critical to any drupal site in my view and should ultimately be a core level feature within drupal already but it isn't. :( We recentley started a new project based upon the Drupal 6 core and would love this module that we have used on many v5 sites to great success to be compatible.

Cheers

robertdouglass’s picture

robertdouglass commented
Issue tags: +Drupal 6 porting

Why are http://drupal.org/node/264971#comment-1027376, http://drupal.org/node/264971#comment-1027548, and http://drupal.org/node/264971#comment-1157636 unpublished? It looks like respectable people from the community have tried to port this to D6. Doesn't unpublishing those comments thwart their progress?

deekayen’s picture

deekayen commented
Status: Postponed » Fixed

I committed #4 with #11. Please file bugs as new issues. 6.x-dev will be out shortly.

Status: Fixed » Closed (fixed)
Issue tags: -Drupal 6 porting

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Drupal 6 porting

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.