Comment preview has bad links for "parent" and "reply"
samo - July 7, 2005 - 13:56
| Project: | Drupal |
| Version: | 5.5 |
| Component: | comment.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Steps to replicate on drupal.org as an authenticated user:
1) go to piece of content that allows comments
2) fill out comments fields ==> preview
3) in the top preview, there will be two links to "parent" and "reply"
--jpg attached
the "parent" link points to: http://drupal.org/comment/reply#comment-
the "reply" link points to itself: http://drupal.org/comment/reply/26423
| Attachment | Size |
|---|---|
| comment-preview.jpg | 16.97 KB |
#1
on my install I am changing this line in comment_preview:
$output .= theme('comment_preview', $comment, theme('links', module_invoke_all('link', 'comment', $comment, 1)));to
$output .= theme('comment_preview', $comment);#2
#3
#4
#5
#6
#7
I don't think this bug is fixed. I am using Drupal 4.6.6 and have the same problem as described by samo.
I go to a piece of content that allows comments - for example forum, or story. I fill out the comments fields and click preview. In the top preview, I see links to parent - edit - reply
Parent link points to
?q=comment/reply#comment-which takes me back to the home page.Edit link points to
?q=comment/edit/and clicking it results in the following error messages:warning: Missing argument 1 for comment_edit() in mysite/modules/comment.module on line 357.
warning: Cannot modify header information - headers already sent by (output started at mysite/includes/common.inc:384) in mysite/includes/common.inc on line 99.
Reply link points to
?q=comment/reply/2and takes me to a page where I can write a new reply to the first reply which was only previewed, never saved.It seems that these links should not be visible or at least not active in the preview window.
Can anyone help?
#8
This is the only comment.module issue I've found that might relate to what I and some others have found. Maybe you guys know whether this is related. There's a problem in comment.module that affects replies to nodes but not replies to other comments. I've posted all my findings here: http://drupal.org/node/63554
#9
Possible related problem is not at ALL descriptive.
#10
Sorry, I didn't realize I was changing the title of the whole thing, just my post.
#11
This can be changed in a theme by overriding the comment.tpl.php.
Anyway, I think it's still a bug that should also be checked against HEAD.
#12
I don't see this behavior in my 5.5 install. marking as fixed.
#13
Automatically closed -- issue fixed for two weeks with no activity.