Download & Extend
Yahoo YUI » Issues

No need to include common.inc in yui_init()

Posted by mustafau on June 5, 2008 at 8:18am
Project:Yahoo YUI
Version:6.x-1.1-2
Component:Code
Category:bug report
Priority:normal
Assigned:bakyildiz
Status:closed (fixed)

Issue Summary

In Drupal 6.x you don't need to include "includes/common.inc" in yui_init().

Login or register to post comments

Comments

#1

Posted by bakyildiz on June 5, 2008 at 8:54am

This is included because of the reported problem http://drupal.org/node/228344 When the cache ise enabled the drupal_add_js() function in common.inc is not visible to yui modules. I will check drupal 6 for the same case.

#2

Posted by mustafau on June 5, 2008 at 8:57am

The issue #228344: When activating cache in "normal" mode, site is unaccessible because of call to undefined function drupal_add_js() is specific to D5. D6 should not be affected. As you can see documentation at http://api.drupal.org/api/function/hook_init calls drupal_add_css() in hook_init(). It is safe to remove require_once './includes/common.inc'; from yui_init() in 6.x-1.x.

#3

Posted by bakyildiz on June 7, 2008 at 4:09pm
Version:6.x-1.x-dev» 6.x-1.1-2
Status:needs review» fixed

#4

Posted by bakyildiz on June 7, 2008 at 4:09pm
Assigned to:Anonymous» bakyildiz

#5

Posted by Anonymous (not verified) on June 21, 2008 at 4:12pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.