Closed (duplicate)
Project:
Project
Version:
5.x-1.2
Component:
Projects
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Jun 2008 at 20:01 UTC
Updated:
6 Jun 2008 at 23:54 UTC
Jump to comment: Most recent file
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | project_module.patch | 3.56 KB | avpaderno |
Comments
Comment #1
aclight commentedThose links are created based on the taxonomy terms themselves, which are capitalized on drupal.org. I probably wouldn't be in favor of making the terms themselves lowercase, but I think this queue is the appropriate place to debate such a thing.
Comment #2
avpadernoThe taxonomy terms are fine to have the first character in upper case, but it's still possible to have the links all in lower case, like the patch does.
Mine is just a proposal.
-- Kiam@AVPnet
Comment #3
dwwThanks for the patch, however:
a) this patch itself has code-style problems
b) please don't fix unrelated problems in a patch (e.g. the existing code-style problems in the nearby menu item definitions).
c)
+ 'title' => $term->name,is an XSS vulnerability for the term name (minor, but we still don't do that).d) nothing here deals with the link rot problem. we should have something that redirects from /project/Modules/* to /project/modules/*.
e) This is duplicate with #89777: Inconsistent capitalization of URLs for project/[Type] pages
So, please don't reply here. Instead, post a new patch over at #89777. Thanks!