Select + textfield

An excellent, feature rich addition to the elements module.

I've only one issue with the current element. Submitting the form below with the 'Second Option' selected will get me 'Second Option' as form value in the submit handler.

Should it not return the _key_ of the option, similar to the way #type select behaves or, when 'Other' has been selected, the value of the texfield?

The same holds for the behaviour of #default_value; shouldn't it accept keys (but then again, what to do when key is the value of the other option?)?

  $form = array();
  
  $options = array(
    'one' => t('First Option'),
    'two' => t('Second Option'),
  );
  
  $form['test'] = array(
    '#type' => 'comboselect',    
    '#title' => t('Example'),
    '#required' => TRUE,
    '#default_options' => $options,
    '#default_value' => 'two', // won't work, needs to be t('Second Option')
  );

To use the element in its current inception, you'd have to pass the #default_options array as #type value to the submit handler so it can reconstruct the key selected . One also has to choose the right translated value for #default_value in the builder.

You want this module: http://drupal.org/project/select_or_other

Actually I've posted in #981530: Port Select (or other) module to D7 to see if the module would like to merge into Elements since I think it would make a lot of sense.

This would be great if Elements and Select or Other merged, then Webform could use all of the fields provided by elements, right now we're only supporting Select or Other, since it's the most important one for us.

Dave, please check back in the Select (or other) issue

Subscribe