I like this module a lot, but I feel like it might be loading a little too much code per page load. I've split the module up into 5 include files (faq.admin.inc, faq.hide_answer.inc, faq.new_page.inc, faq.questions_inline.inc, and faq.questions_top.inc) in order to reduce the overall memory footprint of the module on non-faq pages. The reason for making a separate include file for each of the layouts is that it seems unnecessary to load code for 3 layouts that won't be used even on the actual faq page. Attached is the patch for this split.

CommentFileSizeAuthor
#1 faq.patch92.17 KBbtsukuda

Comments

btsukuda’s picture

StatusFileSize
new92.17 KB

Shoot, I don't think my patch attached. Re-atttempting to attach patch; please forgive if it already is...

nancydru’s picture

@btsukuda: Don't worry, you're not losing your mind. The missing attachment problem has been reported by several people (http://drupal.org/node/267884).

If I get a few spare minutes, I'll try this out.

stella’s picture

Status: Active » Fixed

I've committed this to CVS, along with a similar one for D5. Thanks for the patch.

Cheers,
Stella

stella’s picture

Released in faq 5.x-2.11 and faq 6.x-1.7.

Cheers,
Stella

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.