I think it would be helpful to have some information on the coding standards page regarding the usage of single/double quotes.

Comments

david strauss’s picture

david strauss
he/him
commented

I support single quotes for everything except:
(1) In-line variable usage (which I discourage).
(2) Translated strings where one can avoid escaping single quotes by enclosing the string in double quotes. One such string would be "He's a good person." It would be 'He\'s a good person.' with single quotes. AFAIK, such escaping isn't handled properly by .pot file generators.

Single quote strings are known to be faster because the parser doesn't have to look for in-line variables.

john morahan’s picture

john morahan commented

Is there a standard for database queries? Queries with embedded single quotes are apparently always double-quoted strings, but other queries seem to use both quote styles. For example, contrast filter_admin_delete_submit with profile_field_delete_submit.

heather’s picture

heather commented
Component: Coding standards » Correction/Clarification

Changed the component to reflect the new component categorization. See http://drupal.org/node/301443

emmajane’s picture

emmajane commented
Status: Active » Fixed

The page http://drupal.org/coding-standards has been updated to include information on 'quoting' standards. It was reviewed by Heine before it was added. Two paragraphs were added. The first is from http://pear.php.net/manual/en/standards.bestpractices.php and the second is a variation on the text from David Strauss (as written above).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.