Allow t() to get at term names in breadcrumb [#269513]

Patch suggested...

--- apachesolr.module_orig 2008-06-11 15:56:54.881082000 -0500
+++ apachesolr.module 2008-06-11 15:57:00.315927000 -0500
@@ -764,7 +764,7 @@
*/
function theme_apachesolr_breadcrumb_tid($tid) {
$term = taxonomy_get_term($tid);
- return $term->name;
+ return t($term->name);
}

/**

Comment	File	Size	Author
#1	apachesolr.patch	1.17 KB	robertdouglass

Comments

Comment #1

robertdouglass commented 13 June 2008 at 06:24

Status	File	Size
new	apachesolr.patch	1.17 KB

Is it standard practice (or wise) to translate term names (seeing as they are not translated by core)? I must confer with Gábor on this.

If we do go with translated terms, I would think we'd need the term translated in the block as well. Patch attached.

Comment #2

gábor hojtsy

he/him

Hungarian

Hungary

commented 13 June 2008 at 06:56

t() is not designed and not supposed to be used on dynamic data. Core never translates user entered data, whenever it can distinguish between data coming from the static code and data coming from user entered input.

Comment #3

robertdouglass commented 13 June 2008 at 07:12

Status:

Needs review

» Closed (won't fix)

@janusman: I think we'll leave it as it is now. The theme system lets you add the t() easily enough.

Comment #4

janusman commented 19 June 2008 at 20:36

Underlining is mine...

t() is not designed and not supposed to be used on dynamic data

@Gábor: and... what *IS*? =)

I'm sure you've gone at this issue before... It's just that I just keep finding module after module where adding a t() fixes my immediate problems for showing taxonomy terms, breadcrumbs, field labels and a bunch of other stuff...!

Please help... or please point me to the right place for this discussion =)