Postal Adress: Textarea better than input-field

Hello,
i created a patch, which does the following things:

• Textarea for the Postal
• Option if a field is required or not.
• Error Messages are now like in every module.
  
  Errornous Fields are outlined and marked red.
• Now you can format the Instructions with filters

I think we should also change the following things:

• review all sentences
  especially the Error Messages
  they have to be more friendly :D
  not just "ERROR: blah blah blah".
  eg. I think "Please sepcify your name" would sound better...
  
  But I'm not an english professional
• Make the Feedback Settings better to understand. (i dont know "Navigation link text:" and "Feedback Page Header:", too)
• the translations are a little bit broken at the moment
  but the changes are minimal; in the most cases deleting of the html-tags would be enough

http://drupal.org/node/27415 is not included... :(

forget the patch above.
I had a little bit time so i changed following things too:

• The Feedback-Settings-Page is now seperatet in logical-form-blocks
• hook_help() implementation for "admin/settings/feedback"

sorry
its not a complete rewrite
but this was my first contribution to drupal and my first time using cvs.
i did a cleanup at the whitespaces and tabs used in the file...
and then i read that it is the best to post the changes as *.patch

if you would use a programm like Winmerge http://winmerge.sourceforge.net/ .
you will see the update isnt tooooo big.

sorry for the work youll get with me... :(

here you get a list of the changes ordered by function:
to see this I removed on both versions (myone and the cvsone) all tabulators and whitespace at the beginning and at the end of a line

function feedback_help()

• added one case
• changed one case
• outsourced one part (from inside t() at the beginning of the function

function feedback_settings()

• big changes
• the things got grouped
• a table for the chackboxes
• general reorganisation

function feedback_page()

• was changed because of the changed "return...." of feedback_validate_data()
• now the the messages are shown at the same time youll see the form again.

function feedback_display_form()

• form_textfield, form_textarea are changed for the if required or not thing
• form_field_name and form_field_email dont get overwrittern by default anymore.

function feedback_validate_data()

• big changes
• all if statements have also to check if the form_field was required
• function returns now true if it has errors, false if not
• the error-Messages are sent through form_set_error()

what I changed beside this?

• everything I saw to follow http://drupal.org/node/318
• marginal things like:
  • foo= bar() ;
    to
    foo = bar();
    or

  • foo() {
     $bar = "";
     $verylongname=blabla();
     bar .="something";
     }
     

    to

    foo() {
     $verylongname	= blabla();
     bar			= "something";
     }
     

i wanted to do a little cleanup as a sideeffect

i hope it helps you reviewing my changes....

yours sincerely

Tobias Maier

---

well, i turn the wheel back...
I will start for every change a patch
here is the first one
changing the postal to a textarea.
as I mentioned above this would be better, because adresses are longer than one line...

cu

Tobias Maier