Port to Drupal 6

Sweet! Testing this today.

Works well. Though still suffers from the bug that the images don't get uploaded to a newly create image album added with the image uploading software. I will apply a patch from d5 and see if I can't get it fixed.

OK, applying the patch from http://drupal.org/node/67421 did the trick. Module worked perfectly for me on a test upload.

Updated the patch to work with 6.x, there were a couple of things missing, incorporated the gallery not associated patch as well. The only thing is that there were a bunch of t() calls within watchdog calls removed by one of the patches.

I've just taken over maintaining this module. It's going to take me a while to get into the swing of things (and I don't have unlimited time by any means), but I do hope to deal with this patch soonish.

My basic plan with the module is to fix the show-stopping bugs in the drupal 5 version of the module, release version 5.x.1.0 and then create a drupal 6 branch. At that point I'll look at this patch.

there is no image_pub module anymore on head....

Yes, I've just looked into this. It appears most of the files in HEAD (apart from the README) have been cvs deleted (last year) and are now dead in the Attic. I will try to retrieve them (hopefully soon) and put them back in HEAD, though I may need some help from the drupal CVS admins.

After that, I propose that HEAD is the site of drupal 6 development until we have the first non-dev version.

I'm busy porting my site(s) to 6.0 almost all modules are done, this image_pub is however a requirement. Can someone give me something that works (singularo comment #4 patched files or egfrith) for now? I also want to test an authentication problem that I have in 5.0.... see http://drupal.org/node/204209

I could start porting from 5 tree myself but that seems overkill

I've now brought back the dead files from the attic and merged the DRUPAL-5 branch into HEAD. Please let me know if you know anything amiss with HEAD.

I haven't had time to try any of the patches yet, though I expect they may not apply since there have been some code changes in the DRUPAL-5 branch since they were created.

The second patch earlier on didn't apply, so I've done some work on tidying up the patch. Here is the result. It doesn't work fully yet; you can log in and create an album, but not put any images there yet. However, I'm posting here in the hope that someone might be able to work on this.

The problem seems to be in _image_pub_image_add().

is there a reason drupal_execute is done?

Why not use image_create_node_from from image?

/**
 * Function to other modules to use to create image nodes.
 */
function image_create_node_from($filepath, $title = NULL, $body = '', $taxonomy = NULL) {

I don't think I discovered image_create_node_from() in the earlier versions of image -- perhaps I missed it.

The potential advantage of drupal_execute() is that it returns the errors that you might get submitting the form, for example if the image size exceeds the limits set by image.module. This can then be passed on as helpful error message to the users. From what I can see of image_create_node_from(), it doesn't do that. Other than that, image_create_node_from() would look to be a good way forward.

Thoughts?

If we are going to use drupal_execute() there needs to be a

$form_state['values']['op'] = t('Save');

in the form object, though this doesn't seem to fix the problem.
See http://api.drupal.org/api/function/drupal_execute/6

I got it to work with image_create_node_from

I'm also creating an issue for image to return a proper error code (http://drupal.org/node/337032). I think that's the way to go. If image changes it's form tomorrow your code breaks and this does not.

I do some pre checking so i can return a decent error for now...

    $filepath = $_FILES[$srcfield]['tmp_name'];
    
    // checking until image_create_node_from returns correct errors
    if (!user_access('create images')) {
      return array('success' => FALSE,
                   'reason' => t('Access denied'));
    }
    // Ensure it's a valid image.
    if (!$image_info = image_get_info($filepath)) {
      return array('success' => FALSE,
                   'reason' => t('Not an image'));
    }
    $node = image_create_node_from($filepath, $caption, $description, array($album->tid));
    if ($node) {
      watchdog('image_pub', '%image was added.', array('%image' => $_FILES[$srcfield]['name']));
      return array('success' => TRUE, 'redirect_url' => $redirect_url);
    }
    else {
      return array('success' => FALSE,
                   'reason' => 'Could not copy the file.');
    }

http://drupal.org/node/204209 is still a problem however....

I'm not convinced that image_create_node_from() is the right way to go right now since is it does not do the checking for file size image_node_form() does. I also think it is unlikely that the elements image form will change tomorrow and there is also the possibility that image_create_node_from() might change its functionality too. In order to get sensible error messages with image_create_node_from(), we have to put in quite a bit of extra code that is similar to code in image module, and I rather avoid that in the interests of cleaner code and maintainability.

However, if image_create_node_from() is modified in future to do the checks that happen with the drupal_execute(), I would consider using it in place of the drupal_execute() method.

The attached patch now works with image 6.1.0.alpha3. I had not read the api page for drupal_execute() properly, and had missed out the include line.

We will have to think more about #204209: User authentification does not work under Gallery Remote. I think that after we have this port to 6 at least as good as the current 5.x version, we should tackle #205535: Gallery Remote: Module incompatible with latest GR protocol, as I think it may have some influence on the authentication problems.

Grrr... I now notice the patch has not been attached. I will have to get it off my home machine this evening... Sorry!

Here is the promised patch.

patch works fine

Thanks for the report bwynants.

Given that there seems to be relatively little interest in this project, I've gone ahead and committed the patch and rolled a release for drupal 6. I don't seem to be able to get the release to appear but not be recommended. Therefore it is "recommended", though ideally I would have some more test results before recommending it.

I'm marking this issue as fixed, though have put up a message on the project page asking for any testing results here.