More improvements to help text on access control pages
Steve Dondley - July 19, 2005 - 19:20
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | user interface text |
| Category: | task |
| Priority: | minor |
| Assigned: | Steve Dondley |
| Status: | patch (code needs work) |
Description
Here's another patch with changes similar to those found on http://drupal.org/node/27062
| Attachment | Size |
|---|---|
| user_21.patch | 3.84 KB |
#1
Patch won't apply to HEAD. Please re-roll.
Robin
I ♥ Bugz
#2
I will gladly reroll it if I can get some kind of guarantee that someone will look at it in a prompt manner. I don't like spinning my wheels. I've rerolled other patches only to have them ignored, too.
#3
Steve Dondley : Any news on this?
I guess it doesn't apply to current version.
Fell free to close the topic.
#4
I'll try this one more time.
#5
#6
+1 to removing the HTML from the strings, though, in the interest of full disclosure, on some other issues there have been complaints about this removing context for translators. We did a bunch of it prior to the D6 release though, so IMHO, this is a good thing.
return '<p>'. t('Set up username and e-mail address access rules for new <em>and</em> existing accounts (currently logged in accounts will not be logged out). If a username or e-mail address for an account matches any deny rule, but not an allow rule, then the account will not be allowed to be created or to log in. A host rule is effective for every page view, not just registrations.') .'</p>';+ return '<p>'. t('Set up username and e-mail address access rules for new <em>and</em> existing accounts (currently logged in accounts will not be logged out). If a username or e-mail address for an account matches any deny rule, but not an allow rule, then the account will not be allowed to be created or to log in. A host rule is effective for every page view, not just registrations.') .'</p>';
These seem to be the same line, and the first one does not appear to be being deleted, so I'm not sure what's up with this. It would be nice to fix language in this string like "will not be allowed to be created or to log in" to just "may not be created or log in"
+ return '<p>' . t('Permissions work together with <a href="!url">user roles</a> to let you control what users can do on your site. Each user role has its own set of permissions. For example, you can give users classified as "administrators" permission to "administer nodes" but deny this power to ordinary, "authenticated" users. This allows trusted users to share the administrative burden of running your site. You can also use permissions to let privileged users access special features and content.', array('!url' => url('admin/user/roles', array('absolute' => TRUE)))) . '</p>';You know, I've just never liked this "ordinary" user business. All my users are special. (That's what I keep telling myself.)
+ return '<p>' . t('Roles work together with <a href="!url">user permissions</a> to let you control what users can do on your site. For example, you might give the "administrators" role special administrative permissions or let "subscribers" access restricted content. Once a role is created, you assign users to them by editing the user\'s profile. Users given more than one role and will enjoy the combined permissions of each assigned role.', array('!url' => url('admin/user/permissions', array('absolute' => TRUE)))) . '</p><p>' . t('By default, Drupal comes with two user roles:') . '</p>' .There are some minor code style issues here with spacing around concatenation operators. Also, "Users given more than one role and will enjoy the combined permissions" has an extra "and" in it.
+ '<li>' . t('Anonymous user: this role is used for users that don\'t have a user account or that are not authenticated.') . '</li>' .Wrap this in " to avoid escaping the apostrophe.
I also think we should wrap things like "Anonymous user" and "Authenticated user" in ems, if we are referring to text that occurs exactly like that elsewhere in the interface.