Closed (fixed)
Project:
Advertisement
Version:
5.x-1.5-rc2
Component:
ad module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Jun 2008 at 13:00 UTC
Updated:
24 Aug 2008 at 17:13 UTC
There are two places that don't pass muster with xhtml validation of ad code within pages:
1. div ID names cannot start with a number.
<div class="advertisement-space" id="290-1"></div><div class="image-advertise ...
2. Many new Drupal themes are xhtml transitional or strict. Target is not allowed in xhtml strict. Would you consider changing this to a javascript function that does the popup? Or, get rid of target "_self" since it's not necessary -- it's implied? This way xhtml strict users could choose the first option (target same page) and still validate.
Thanks.
Comments
Comment #1
jeremy commented#2 is a duplicate issue. Please review the proposed fix there.
I'll leave this issue open for #1, a simple fix.
In the future, please limit each issue to only 1 bug report. Attempting to cram multiple bug reports into one issue inevitably leads to issues being lost/ignored/forgotten.
Comment #2
jeremy commentedFix committed.
Comment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.