Use token module for the email body and subject
greggles - June 21, 2008 - 00:04
| Project: | Comment Notify |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
As title says. We should be using the token module for the tag replacement in the email bodies. This will reduce the amount of code in comment_notify and increase the features for users.
#1
This is surprisingly more complex than I thought. Some of the things we need don't have tokens. It will also take multiple calls to token_replace to get this done.
I'm tempted to postpone it and make it 6.x only...
#2
Yeah, 6.x only.
#3
What the heck - subject too.
#4
I'd like to get this module included into Drupal core. Creating a dependency on token module is likely to complicate that.
Looking at the code of this module, I don't see a strong need to use token module. The code is easy to read and understand as it is.
#5
I know that's an old comment of yours, Dries, but IIRC, we came to the conclusion that we were going to work on getting Token into core as well? No? So that shouldn't be a problem anymore, should it? Quite the contrary, I would guess, as it would presumably lead to more code re-use.
#6
The 7.x version now uses tokens. I don't think it's worth backporting that.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.