Download & Extend

Add support for the keys_api module

Project:Location Map
Version:7.x-1.0
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

Currently you must change the Google Maps API key when you move a site from http://localhost/ to http://www.example.com/

If this module would support the keys_api module you wouldn't have to do anything at all. See http://drupal.org/project/keys_api

Comments

#1

+1

Keys API has change name to Keys: http://drupal.org/project/keys.

#2

If you use local domain routing on your development machine—so that even during development on your local machine you are still browsing to http://www.example.com/—this issue does not occur and you can use the same API key during development and deployment. For a whole range of reasons, anyone who is developing on http://localhost/ should certainly look into this... see VirtualHostX or MAMP Pro on the Mac, similar products on other platforms.

If there is still interest in this feature, I may look at implementing it as being optionally supported if the Keys module is installed... However, at this point new features will only be added to the Google Maps location 6.x-2.x-dev branch (to be created), so unless someone else chooses to backport it this will not be available on 5.x sorry.

#3

Status:active» closed (fixed)

In fact, Google states that if you are surfing from http://localhost you do not need a Google Maps API key. The only exception to this appears to be if you are using a specific port number locally, such as http://localhost:1234 for development—in that case you need to apply for a key.

Since in the latter case I can't see that you'd want to ship out to your client a database installed with your custom localhost development key, I can't see there is a problem here. On that basis, I can't see much point in adding Keys module support—the whole purpose to this module is to be a simple alternative to the more complex options for a basic use case.

At this point therefore I'm going to close this issue. Feel free to re-open if you have additional information that might change the balance of the discussion.

#5

Status:closed (fixed)» active

keys support allows google maps to work for domains with and without the www. on the domain name.

#6

Version:5.x-1.0» 6.x-2.x-dev
Status:active» postponed

Well... maybe one day. But almost certainly only in 6.x-2.x and above.

#7

The Google API key does NOT work in Drupal 6.16. I have done everything to make the damn thing work but nada. The minute I click to locations, the system tells me I need the key. Please fix this as redoing the same drill on this is a drag. The google module works without a problem, setting, etc., etc but the key doesn't hold.

#8

Status:postponed» patch (to be ported)

I made a patch, (using the gmap module) to solve this problem. It is a very untested patch.

AttachmentSize
gmaplocation-275647.patch 4.01 KB

#9

Status:patch (to be ported)» needs review

Correcting status. Will have a look at this.

And @remoran:
a) don't post responses to postponed issues and expect a response.
b) don't hijack issues with unrelated support requests; post a new issue and tag it "support request".
c) I don't know if there was a problem with this module and 6.16, but I certainly didn't see one or get any other reports of problems. You'd need a much clearer description of the bug on a clean install, with steps to reproduce, to get much traction on a bug report when no one else is experiencing it.

#10

Project:Google Maps location» Location Map
Version:6.x-2.x-dev» 7.x-1.0-beta2

Location Map module is the successor to gmaplocation for Drupal 7. Any features to be added to the module must first be implemented there, and may then be backported to gmaplocation for Drupal 6. Moving this to the Location Map module issue queue.

#11

Version:7.x-1.0-beta2» 7.x-1.0
Status:needs review» closed (won't fix)

Rather than adding support for the keys_api module, the Location Map module is going to be migrated to V3 of the Google Maps Javascript API, that does not require API keys.

#12

Status:closed (won't fix)» active

About that migration to gmaps api v3, i made small upgrade on my site about that. It would be nice if you would like to implement some changes or just have a look at it -> in attachment. Its small update of locationmap 7.x-1.0 to use gmap api v3.

AttachmentSize
locationmap_private_update_gmap_api_3.zip 5.19 KB

#13

Thanks daimooni. I've uploaded a patched version 1.1 to my git account:
https://github.com/LeisureLarry/Drupal7-Modules-Locationmap

It supports both V2 and V3 (just don't enter a key).
Besides it allows interactive maps in blocks.

nobody click here