Allow user to have a phone type (Mobile, Home, Office, etc) associated with a phone number. [#275861]

I took a different approach than http://drupal.org/node/205651 with this patch. I have included a CSS file to help format it correctly in the form, and I also added an install file to handle the update from one -> two fields. The update works with both single and multi-fields. This patch file applies cleanly against 5.x-2.11

Comment	File	Size	Author
#2	phone.type_.after_.range_.diff	8.56 KB	liveoutloud2day
#1	phone.type_.diff	8.48 KB	liveoutloud2day

Comments

Comment #1

liveoutloud2day commented 27 June 2008 at 19:47

Status	File	Size
new	phone.type_.diff	8.48 KB

Woops - how about the patch file?

Comment #2

liveoutloud2day commented 27 June 2008 at 19:50

Status	File	Size
new	phone.type_.after_.range_.diff	8.56 KB

Oh - the above patch applies cleanly with any of the patches I submitted, except in combination with this one - http://drupal.org/node/275837 - This version of the patch applies after you have applied the "range" patch.

Comment #3

thierry_gd commented 28 July 2008 at 20:47

Hi,

I think you forgot in phone.css to define the following elements :
phone-fields-end-wrapper
phone-field-end-wrapper

Comment #4

Freso commented 11 March 2009 at 14:55

Status:

Needs review

» Needs work

You'll probably want to add some t() calls.
E.g. $order_options = array('Mobile' => 'Mobile', 'Home' => 'Home', 'Office' => 'Office', 'Apt' => 'Apt', 'Dorm' => 'Dorm', 'Fax' => 'Fax'); should probably be

 $order_options = array(
  'Mobile' => t('Mobile'),
  'Home' => t('Home'),
  'Office' => t('Office'),
  'Apt' => t('Apt'), // Perhaps "Apartment" instead, for the value?
  'Dorm' => t('Dorm'),
  'Fax' => t('Fax'),
);

Both for better compliace with Drupal's coding standards (the array formatting), but also so that you're able to translate the values of the array keys. You'll probably want to use t() when presenting the value as well.