The contact.module of the Drupal HEAD does now nearly the same as the feedback.module.
kbahey and I talked about to bring them together.
To have just one module.

a) Here comes a list of features which you can find in feedback.module and which are currently missing in contacts.module

  1. add the following fields to contacts.module:
    • Postal Address
    • Phone Number
    • A real "Message Subject" (You say "What?? we have one!" - this one is used in the false way. Be patient i'll tell you later what i mean)
  2. make it configurable if these fields are shown on the Sites Contact-Page and/or on the Users Contact-Page
  3. Make it configurable which field is required and which one not
  4. The Subject field is currently used to select on which team/department the message belongs to.

    this field should be renamed to topic/category/department (just one of them / maybe let the user decide)
    and a Subject field with the default behavour should be introduced.
  5. let the "Additional information:"-field be formatted. So add form_format()
  6. Feedback has a feature "Log all feedback attempts to watchdog"
  7. it also allows you to add an special "Subject Prefix:" to the e-mail which will be sent.
  8. and to customize the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure")

    (personally i think this is not really needed)
  9. it also allows you to define a "Navigation link text" and a "Feedback Page Header" - but the most users (including me) were a little bit confused about what that means

    (personally i think this is not really needed)

b) here comes my list what i want to see beside the things mentioned above in contact.module:

  1. why does contact have two places to configure it (admin/contact and admin/settings/contact)

    i think they should be merged into one. So that it is easier for the User to get into this.
  2. Help texts, everywhere :D
  3. a new permission:
    "Let me use all Users Contact page" - allow specific Roles to contact the User through the Contact-Page, also if he deactivated it

Please tell me what you think about it and if you have other ideas.
I want to start to merge the feedback module into the contact module soon

Yours sincerely

Tobias Maier

CommentFileSizeAuthor
#15 contact.module_5.patch9.65 KBTobias Maier
#13 contact.module_4.patch10.97 KBTobias Maier
#12 contact.module_3.patch10.76 KBTobias Maier
#11 updates.inc_3.patch1.13 KBTobias Maier
#10 database.pgsql_5.patch634 bytesTobias Maier
#8 contact.module_2.patch11.02 KBTobias Maier
#7 database.mysql_5.patch720 bytesTobias Maier
#6 contact.module_1.patch10.38 KBTobias Maier

Comments

Tobias Maier’s picture

Tobias Maier commented

i forgot to mention that it also sends the referrer in the E-Mail
what I also want to include

lennart’s picture

lennart commented

Hi Tobias,

I am currently using both feedback.module and contact.module, so for me a merging would generally make sense.

I agree with most of your ideas except; I do not think " the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure") " is not needed.

I think this should stay.

It gives comfort and certainty to the user to know that the mail has been sent succesfully

Regards
Lennart

Tobias Maier’s picture

Tobias Maier commented

i think also that this messages should stay there, but I think they don't have to be customizable, like in Feedback.

kbahey’s picture

kbahey commented

Tobias,

Thanks for the comparison.

As the author of Feedback, I see a lot of overlap between contact and feedback. I would like to see them merged, and become part of core.

contact is a good base to build on, and has some extra features (most importantly the ability to contact a specific user, as well as list different topic/category and route the message accordingly (think of sales, support, marketing, ..etc or complaint, comment, request, ...etc.)

Add to all that one feature present to neither: a checkbox to send a copy of the email to the originator for filing.

If both merge and add the above feature, I will be very happy, and feedback can then rest in peace starting from 4.7.

Tobias Maier’s picture

Tobias Maier commented

here are the first patches regarding this:

  1. [bugfix] if contact.module is unconfigured the form gets shown
  2. [bugfix/new feature] hide subject if there is just one
  3. [new feature] input format for contact.module
  4. [bugfix] Side-wide contact form: doesn't save entered text on input error reload

please test them all and integrate them all as fast as possible, because i want to develop the next steps on top of them

Thanks

Tobias Maier’s picture

Tobias Maier commented
Title: Comparsion between contact.module and feedback.module » merging feedback.module into contact.module
StatusFileSize
new contact.module_1.patch10.38 KB

and here comes the first all-in-one patch:
please try it, and tell me if it works for you:
This is just the first step to solve the list above so there come much more enhancements later...

Changelog:

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new database.mysql_5.patch720 bytes

the patch for the mysql-table

Tobias Maier’s picture

Tobias Maier commented
Status: Active » Needs review
StatusFileSize
new contact.module_2.patch11.02 KB

contact.module updated again
-->now it runs :D

dries’s picture

dries commented

- You need to provide an update for updates.inc too.
- You need to provide an update for database.pgsql.
- Please drop the filter stuff for now.
- Please don't capitalize the words category and subject in + form_set_error('subject', t('You must enter a Subject.')); and + form_set_error('category', t('You must select a valid Category.'));.
- If there is only one category, we probably don't need a hidden category either?

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new database.pgsql_5.patch634 bytes

If there is only one category, we probably don't need a hidden category either?

if I don't send it hidden I have to count the number of available categories at the field validation.
I think this is the best way, because I don't have so much sql queries.

Please drop the filter stuff for now.

why? if it has security reasons than it would be a solution only to allow the dafault filter.

here is the update
- removed filter
- changed the words to lowercase
- update for updates.inc
- update for database.pgsql

I was not able to test the pqsql things...

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new updates.inc_3.patch1.13 KB

updates.inc.patch

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new contact.module_3.patch10.76 KB

contact.module.patch

it includes the hidden input field

maybe I release one without it...

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new contact.module_4.patch10.97 KB

and here comes the patch without the hidden form field

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to HEAD. Thanks.

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new contact.module_5.patch9.65 KB

after the first part was commited to HEAD
I want to start with the second:

* added phone number
* added postal address
* you can configure which field should be shown and which one not
* you can configure which field is required
* referrer is sent with site-wide contact form
* settings page is a little bit changed (I hope you like it)
* [bugfix/feature] whitespaces were trimmed on $edit[]
* [bugfix] site_name readded to subject...

the email which will be sent could _maybe_ improved.
the best would be html but this is not allowed :(

Tobias Maier’s picture

Tobias Maier commented
Status: Fixed » Needs review
Crell’s picture

Crell commented
Status: Needs review » Needs work

Patch in #15 needs to be updated to the new form API.

Tobias Maier’s picture

Tobias Maier commented

I will release seperate patches for all relevant bugfixes/features

Jaza’s picture

Jaza commented
Version: x.y.z » 6.x-dev

Still needed? I'm not sure... I'd like to see contact.module be upgraded with the ability to add custom fields, rather than simply add a whole lot more system-provided fields to it.

anyway, moving to 6.x-dev queue.

BioALIEN’s picture

BioALIEN commented

Jaza beat me to it. I was just about to say, contact.module should follow the path of profile.module and allow for the addition of custom fields, specify required fields etc. This will also slow down the spam invasion as not all contact forms will be identical (without the need for additional contrib modules).

Put me down for testing :)

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Just my two cents worth: The Contact_List module adds functionality that I can't believe isn't already there. It should be a minor merge effort. The main thing it adds is the ability to "pre-select" the category (recipient) from a link (<a href="/contact/Sales+Department">contact the Sales Department</a>).

I also like the "Contact List" intercept rather than the drop down selector, but others may not. The Contact_List also adds a bit more customization to the contact form.

bradlis7’s picture

bradlis7 commented

I've got a patch for the referrer at Issue# 183661. It's currently not working, but any discussion about it should go there.

bradlis7’s picture

bradlis7 commented

In reply to #21, see Issue 183678.

catch’s picture

catch
he/him
Primary language English
commented
Version: 6.x-dev » 7.x-dev
behindthepage’s picture

behindthepage commented

I vote also for customizable fields as stated in #19 and #20.

Would this be a good time to consider merging Contacts Forms as well so that when you specify a category eg. contact/Sales_Department you can have a customizable "additional info" and choose whether the drop down category menu shows. If you are going to add half the features of my module the other half is only another step. Although I think it is important to keep the admin as simple as possible and if that means leaving features out and having add on modules then I am all for that.

I am happy to contribute some code for customizable fields and for merging Contact Forms.

Regards
Geoff

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Closed (duplicate)

Let's make sure we have all separate issues for each feature please. Marking this issue as a duplicate.