if you have just one Subject the Subject field is not shown because you have no choice to select another subject.
it is also possible to show its name.
but this patch hides it

hope you like it

CommentFileSizeAuthor
contact_nochoise.patch1.18 KBTobias Maier

Comments

kbahey’s picture

I prefer that we not use the subject at all this way.

What should be a drop down list must be topic/category, and subject must be manually entered by each user.

For example, category can be "drupal.org web site problem" and subject can be "cannot post a project" or "bad formatting of wide pages".

Tobias Maier’s picture

this is just one step of my work
they saied "make many small patches" and this is what I do...
you got an email with a patch which does what you want

kbahey’s picture

But, if you are to do it the right way later, it will overwrite that fix that you just provided a patch for.

It will also create more load on others (review patchs, apply patches, ...etc. will happen twice).

So, for patches, do provide many small patches (which are easier to understand and review) , but do not make them cancel each other or change what a previous patch did.

Tobias Maier’s picture

now you can forget this patch and apply directly this one
merging feedback.module into contact.module
it has much more improvements and bugfixes

Tobias Maier’s picture

Status: Needs review » Fixed

is fixed in HEAD

christian.bender@fuenfzehndreissig.com’s picture

mkerres’s picture

Anonymous’s picture

Anonymous’s picture

Tobias Maier’s picture

Version: x.y.z » 4.6.3
Assigned: Unassigned » Tobias Maier
Status: Fixed » Closed (fixed)