Closed (fixed)
Project:
Drupal core
Version:
4.6.3
Component:
contact.module
Priority:
Minor
Category:
Feature request
Assigned:
Reporter:
Created:
30 Jul 2005 at 01:17 UTC
Updated:
7 Oct 2005 at 06:37 UTC
if you have just one Subject the Subject field is not shown because you have no choice to select another subject.
it is also possible to show its name.
but this patch hides it
hope you like it
| Comment | File | Size | Author |
|---|---|---|---|
| contact_nochoise.patch | 1.18 KB | Tobias Maier |
Comments
Comment #1
kbahey commentedI prefer that we not use the subject at all this way.
What should be a drop down list must be topic/category, and subject must be manually entered by each user.
For example, category can be "drupal.org web site problem" and subject can be "cannot post a project" or "bad formatting of wide pages".
Comment #2
Tobias Maier commentedthis is just one step of my work
they saied "make many small patches" and this is what I do...
you got an email with a patch which does what you want
Comment #3
kbahey commentedBut, if you are to do it the right way later, it will overwrite that fix that you just provided a patch for.
It will also create more load on others (review patchs, apply patches, ...etc. will happen twice).
So, for patches, do provide many small patches (which are easier to understand and review) , but do not make them cancel each other or change what a previous patch did.
Comment #4
Tobias Maier commentednow you can forget this patch and apply directly this one
merging feedback.module into contact.module
it has much more improvements and bugfixes
Comment #5
Tobias Maier commentedis fixed in HEAD
Comment #6
christian.bender@fuenfzehndreissig.com commentedComment #7
mkerres commentedComment #8
(not verified) commentedComment #9
(not verified) commentedComment #10
Tobias Maier commented