Closed (won't fix)
Project:
Page Title
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Jun 2008 at 13:54 UTC
Updated:
2 Nov 2010 at 00:35 UTC
Jump to comment: Most recent file
Comments
Comment #1
Vidarls commentedThis is because when you use panels to override the node/% url, the page loaded is no longer a node, it is a panels page. Modules that expect a node page to be loaded, and not a panels page will not behave as they are intended to when using panel node/% override. I believe that it is mostly modules that tries to modify the "menu" part of any node (I'm lacking in my english here; what I mean is for example breadcrumbs, menu entries and titles) that will fail when using panels node/% override. Modules that modifies other part of the node (CCK, links, filters etc) are generally not affected by panels.
A possible solution for you might be using workflow-ng (http://drupal.org/project/workflow_ng) to set the page title to a custom value during page load. I have described a way of doing that in this issue: #274004-2: Panel pages and breadcrumbs regarding breadcrumbs. But you can basically use the same approach to page titles, replacing the set breadcrumb action with set page title action.
Comment #2
Vidarls commentedChanging this to a support request.
@summit: you could raise an issue against page_title module with a feature request to support panels pages
Comment #3
summit commentedHi Vidar,
Could you explain with code exactly what I have to do to get this working for page_title?
Thanks in advance for your reply!
greetings,
Martijn
Comment #4
Vidarls commentedI'm not sure what you're after. There is no coding incolved in setting workflow_ng up to set the page title.
I don't know what is required to make page_title module support panel pages if that is what you are after.
Comment #5
sunMoving over to Page Title project. Panels is not able to do anything about this issue.
Comment #6
nicholasthompsonCan you please confirm what versions of modules/core you are using here please so I can try to accurately replicate?
Comment #7
nicholasthompsonI think I understand the problem - marking as active as I'm investigating this....
Comment #8
jenlamptonI think what everyone wants (me too, me too!) is Panels integration. I.E. a field on the build/panels page that lets you set a custom page title for that panel. NodeWords (aka Meta Tags) also has an example of how to do this...
also take a look at the _nodewords_detect_type_and_ids() function.
Jen
Comment #9
jenlamptonI added panels integration in my update to this module, available here:
http://drupal.org/node/284218#comment-1077364
Jen
Comment #10
wflorian commented+subscribe
Comment #11
dkruglyak commentedSince I happen to need this integration immediately I just bit the bullet and developed it!
This is not a polished solution, but a quick hack that gets the job done for me. The idea is to add another condition check in
page_title_get_title()and if the active menu matches panel's delegator, emulate its handler code to construct and retrieve the page title.Note, my fix works with Panels 3, which is the only version that will be supported going forward.
Comment #12
wflorian commentedIs the patch also working for D5 versions?
Comment #13
dkruglyak commentedNo, this patch is only for Panels 6.x-3.x, which is a complete rewrite of Panels.
Comment #14
jenlamptonI haven't worked on this since last year, silly to keep it assigned to me!
thanks dkruglyak for taking over!
Jen
Comment #15
pyxio commentedYes, this pretty important. I'm curious if and when the patch will be integrated into a module release. I don't liked patching if I don't have to. Thanks for the fantastic module ... especially the term page titles introduced in the last release. awesome! cheers, kevin
Comment #16
wflorian commentedAnybody out there who is also still interested in a working solution for Panels 2 for Drupal 5.x.
Maybe somebody is capable of doing a backport? I would be willing to support your work with a little extra money.
Comment #17
crea commentedPatch from #11 needs work anyway cause there is no more delegator but page_manager is.
Subscribing
Comment #18
crea commentedActually, I don't understand why Page Title doesn't work for Panels: Panels set up page title via drupal_set_title() and it should be available in Page Title module, cause it uses drupal_get_title() for fallback in page_title_get_title(). But for some reason drupal_get_title() returns wrong title there (from menu_get_active_title() function). Trying to investigate that atm.
Comment #19
crea commentedSetting it as active bug, cause I think there should not be any "integration" as Panels itself sets up titles properly via drupal_set_title() and Page Title module only needs to play nice with it.
Comment #20
crea commentedComment #21
crea commentedLet's deal with 6.x issues separately and leave this for 5.x version as it was originally before dkruglyak spoiled it.
Comment #22
jenlamptonI have a version of this module I managed to get working with Panels 5.x-1.2. I started working on it back in Page Title 5.x-2.0 but a lot has changed since then!
I thought I would have had more time since then to do a diff and see if I could merge my changes back into head for the 5.x branch, but since I don't seem to be getting around to it, this is my Page Title 5.x-2.0 version. It "works" but I'd love it if any of you devs with more time could take over and get it up to snuff for the community.
Sorry again for my tardiness!
Jen
Comment #23
summit commentedSubscribing, will look into your module Jen for a Drupal 5 site of mine.
EDIT: Hi, I am not able to get it working. it gives a taxonomy pages option, but NO panel-pages support with my small knowledge..
sorry if I am mistaken..
Greetings,
Martijn
Comment #24
nicholasthompsonI've decided that 2.3 shall be the last of the DRUPAL-5 releases. I simply do not have the bandwidth or energy to maintain that branch anymore. If anyone wishes to become a co-maintainer for the DRUPAL-5 branch, please contact me.