Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.gagarine writes, in a different issue:
In the filter for view2 they have:
Flags: Flagged
Filter to ensure a node has or has not been flagged.
Flags: Flagged time
Display the time the node was flagged by a user.But what don't have another filter :
Flags: user id
Display the node flagged by this user
This isn't a bug per se. The "by current user / by any user" filter is now a setting on the relationshoip itself, so we still have this functionaility.
Also, since the "Flag: User ID" relationship can be brought in, we then have access to the "User: Current" filter. We can also expose this filter.
So it seems everything is alright. However, I'm filing this issue so that people can have a place, for the time being, to voice their opinions and ideas.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | flag_user_flagged_argument.patch | 479 bytes | voxpelli |
Comments
Comment #1
mooffie commentedJust an idea, for brainstorming:
Our current "Flags: Flagged" filter looks like:
We could change it into:
But, of course, the question is: "is this needed?" If there's a need, we can easily do this. But perhaps there isn't a need.
Comment #2
quicksketchI think combining the existing features makes more sense than making redundant features. Otherwise you'll get a view where inexperienced users are configuring the option 3 times, just to make sure it takes effect. "Yes, only include content by this user. Oh, yeah i definitely want to filter to include include this user. Wait, this filter restricts to this user only also? I better add it too just in case".
Then the situation could get worse when one of the options is set to "all users" but the relationship is set to "this user only". So anyway, my vote is that don't add more filters for the same thing.
Comment #3
gagarine commentedYes i need this for exemple to create a view with the id of user in argument. Something like that: /user/userid/flagged where userid is the argument. This view display all flagged item for the specified user so any one can view what this user have flagged (like the "track tab" -> http://drupal.org/user/162439/track ).
So the "Flagged by any user" is not enough, I need "Flagged by this user id". Perhaps you know an other way to do that?
Anyway if it is possible combine feature is better.
Thanks for the brainstorming :)
Comment #4
quicksketchOh! Yes, we certainly need a UID argument then! I just looked through all the options and it doesn't look like that's currently possible. Let's make this a feature request.
Comment #5
mooffie commentedWe already have a UID argument: that of Views. Just pull in the "Flag: User ID" relationship and you'll have access to the "User: Uid" argument. One already has to pull in this relationship to have access to "User: Name".
It doesn't seem obvious to us Views 1 guys (I myself forgot about this possibility when I initially wrote the message at the top, about seemingly not having a "User: Current" filter), but I believe people will feel very very comfortable with this "relationship" things.
Comment #6
quicksketchDoh! You're right! I thought there was one. Seems like this is mostly an education issue, even for us :)
Comment #7
mooffie commentedBTW, I think we should name this relationship "Flag: User" instead of "Flag: User ID".
I've just filed a Views issue, #277382: Remove "ID" suffix from relationships labels, and if Earl thinks it's the right thing to get rid of these "ID"s, then we'll get rid of ours too.
Comment #8
quicksketchLooks like the "ID" was removed from the UI in Views. This commit removes it from our interface as well.
http://drupal.org/cvs?commit=134294
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #10
voxpelli commentedI'm reopening this issue since the built in UserID in Views can't be targeted for the flagging users in a user view showing flagged users - it always assumes that it's the flagged users that should be filtered by the uid and you can't tell it that it instead should filter so that all users flagged by a specific user is shown - at least as I can see.
I solved it by doing an addition to the flag module - maybe it should be solved by a change of functionality in views instead, but until then it can be useful to add this functionality to the flag module.
I'm attaching a simple patch for this.
Comment #11
quicksketchYou can do this by using the process described in How to setup a "Who's bookmarked this" tab. Just use a user-based flag instead of a node-based one and every thing works identically. So you can set up a "Friends" tab on the user profile page for example.
Just a note that the options described by mooffie in #1 were implemented in #403602: Views Flagged Filter Option for Any due to the solid argument made there regarding its usefulness in exposed filters.