Download & Extend
Issues

Add tests for vocabulary hierarchy

Posted by Damien Tournoud on July 1, 2008 at 1:35pm
Project:Drupal core
Version:7.x-dev
Component:taxonomy.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7, Novice

Issue Summary

Vocabulary hierarchy was always changed to single after term edit. This been fixed in #762604: Taxonomy terms list broken, term add/edit forgets it's parent
But we still has no test for "flatness" and this issue fixes it with more clear/readable condition in code

To reproduce:

  • Create a new vocabulary, on the term list page, you see "flat vocabulary"
  • Add any term, on the term list page, the vocabulary type changed to "single hierarchy"

Expected behavior: the vocabulary type should stay in "flat vocabulary" as long as there is no parent/child relationship in the vocabulary.

Login or register to post comments

Comments

#1

Posted by Damien Tournoud on September 24, 2008 at 10:48pm

The issue comes from the identification of the root element. Here harmonized for consistency.

AttachmentSizeStatusTest resultOperations
277200-detect-hierachy-type.patch1.51 KBIdleFailed: 7241 passes, 4 fails, 0 exceptionsView details

#2

Posted by catch on September 25, 2008 at 8:45am
Status:active» needs review

This is a patch. Could use a test.

#3

Posted by Anonymous (not verified) on November 12, 2008 at 6:40am
Status:needs review» needs work

The last submitted patch failed testing.

#4

Posted by andypost on April 5, 2010 at 6:03pm

Is this still an issue?

#5

Posted by andypost on April 6, 2010 at 1:51pm
Status:needs work» needs review

Fix with test

EDIT: parent for [root] is not set #762604: Taxonomy terms list broken, term add/edit forgets it's parent

EDIT2: new issue about hierarchy #763380: Do not use taxonomy_get_tree() in taxonomy_overview_terms()

AttachmentSizeStatusTest resultOperations
277200-detect-hierachy-type-d7.patch1.45 KBIdlePASSED: [[SimpleTest]]: [MySQL] 19,037 pass(es).View details

#6

Posted by andypost on June 29, 2010 at 3:50pm

Re-roll last patch suppose no need to wait debatable #763380: Do not use taxonomy_get_tree() in taxonomy_overview_terms()

AttachmentSizeStatusTest resultOperations
277200-detect-hierachy-type-d7.patch823 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 21,944 pass(es).View details

#7

Posted by andypost on June 29, 2010 at 4:09pm

taxonomy.module hunk was lost

AttachmentSizeStatusTest resultOperations
277200-detect-hierachy-type-d7.patch1.45 KBIdlePASSED: [[SimpleTest]]: [MySQL] 21,951 pass(es).View details

#8

Posted by andypost on July 30, 2010 at 4:57am

Re-roll against current HEAD

AttachmentSizeStatusTest resultOperations
277200-detect-hierachy-type-d7.patch1.45 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 277200-detect-hierachy-type-d7_2.patch. See the log in the details link for more information.View details

#9

Posted by andypost on July 31, 2010 at 4:12pm

Seems this was fixed in #846524: Terms cannot be manually reordered by weight.

So patch still useful
- Adds a test
- isset() a bit faster then array_shift() + compare

#10

Posted by xjm on November 17, 2011 at 5:01am
Status:needs review» closed (fixed)

#11

Posted by andypost on November 28, 2011 at 5:29pm
Status:closed (fixed)» needs review

I think this should be commited

#12

Posted by andypost on November 28, 2011 at 5:29pm

#8: 277200-detect-hierachy-type-d7.patch queued for re-testing.

#13

Posted by xjm on November 28, 2011 at 5:30pm
Version:7.x-dev» 8.x-dev

Sorry, I thought you said in #9 that the issue was fixed. Can we update the title and issue summary to reflect what the current patch is for?

#14

Posted by System Message on November 28, 2011 at 5:30pm
Status:needs review» needs work

The last submitted patch, 277200-detect-hierachy-type-d7.patch, failed testing.

#15

Posted by andypost on November 28, 2011 at 7:45pm
Status:needs work» needs review

re-roll for 7 & 8

AttachmentSizeStatusTest resultOperations
277200-detect-hierachy-type.patch1.19 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 277200-detect-hierachy-type.patch. Unable to apply patch. See the log in the details link for more information.View details
277200-detect-hierachy-type-d7.patch1.15 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 277200-detect-hierachy-type-d7.patch. Unable to apply patch. See the log in the details link for more information.View details

#16

Posted by andypost on April 12, 2012 at 9:41am

#15: 277200-detect-hierachy-type.patch queued for re-testing.

#17

Posted by System Message on April 12, 2012 at 9:42am
Status:needs review» needs work

The last submitted patch, 277200-detect-hierachy-type-d7.patch, failed testing.

#18

Posted by andypost on April 12, 2012 at 10:31am
Status:needs work» needs review

Re-rolled patch with test

EDIT: summary updated

AttachmentSizeStatusTest resultOperations
277200-detect-hierachy-type-18.patch1.25 KBIdlePASSED: [[SimpleTest]]: [MySQL] 36,281 pass(es).View details

#19

Posted by no_commit_credit on April 12, 2012 at 5:57pm

Attached merely removes t() from the assertion message, which is not actually translated. Reference: http://drupal.org/simpletest-tutorial-drupal7#t

AttachmentSizeStatusTest resultOperations
vocab-hierarchy-277200-19-test.patch1.24 KBIdlePASSED: [[SimpleTest]]: [MySQL] 36,263 pass(es).View details

#20

Posted by xjm on April 12, 2012 at 5:58pm
Status:needs review» reviewed & tested by the community

Ah, I understand now. So the current patch does not include any functional changes. Instead, it includes:

  1. A code cleanup.
  2. An automated test to codify the correct behavior.

Patch looks good to me. Thanks @andypost for pushing this forward. :)

#21

Posted by catch on April 17, 2012 at 3:06am
Title:Adding a term change the hierarchy type of the vocabulary to "single hierarchy"» Add tests for vocabulary hierarchy
Version:8.x-dev» 7.x-dev
Category:bug report» task
Status:reviewed & tested by the community» patch (to be ported)

Thanks, committed/pushed to 8.x, moving to 7.x for backport.

#22

Posted by xjm on April 17, 2012 at 9:52am
Issue tags:+Novice

Should be a simple backport.

#23

Posted by andypost on April 17, 2012 at 3:10pm
Status:patch (to be ported)» needs review
AttachmentSizeStatusTest resultOperations
277200-vocab7.patch1.15 KBIdlePASSED: [[SimpleTest]]: [MySQL] 38,691 pass(es).View details

#24

Posted by xjm on April 17, 2012 at 9:24pm
Status:needs review» reviewed & tested by the community

Thanks @andypost!

#25

Posted by webchick on May 1, 2012 at 4:45am
Status:reviewed & tested by the community» fixed

That's certainly much easier to read. and yay for tests.

Committed and pushed to 7.x. Thanks!

#26

Posted by System Message on May 15, 2012 at 4:50am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.