Hi,

A smaller bug, but it bit me when I was making a change in activeMailLib.php.

Currently, the From() method is called as:

$email->From($mail->from_name . ' <' . $mail->from_address . '>');

activeMailLib->From has a function definition of:

function From($from,$name=false){

And will use the $from and $name in outputting the From address as follows:

	if ($this->mailfrom){
		if ($this->mailfromname) $this->headers["From"] = $this->mailfromname." <".$this->mailfrom.">";
		else $this->headers["From"] = $this->mailfrom;
	}

So we don't need to combine the name and address ourselves. This patch makes the 1 line change which is much shorter than my explanation :-)

Cheers,
Eric

CommentFileSizeAuthor
simplenews.module.from_name.patch764 bytesejort

Comments

DriesK’s picture

Just for the record: it's is not because I did't respond to your issues, that I'm not interested. I'm now changing Simplenews to support subscription to multiple newsletters, and the code is changing thoroughly. When I'm finished, I will try to include all your 3 patches, but I'll first have to investigate whether they still work properly with the new code.

thanks for your efforts!

DriesK’s picture

Status: Needs review » Fixed
osherl’s picture

Anonymous’s picture

DriesK’s picture

Status: Fixed » Closed (fixed)

Closed because the automatic close feature in project module is broken, and the issue list is becoming cluttered.