Closed (fixed)
Project:
Simplenews
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Jul 2005 at 06:13 UTC
Updated:
25 Sep 2005 at 17:50 UTC
Hi,
A smaller bug, but it bit me when I was making a change in activeMailLib.php.
Currently, the From() method is called as:
$email->From($mail->from_name . ' <' . $mail->from_address . '>');
activeMailLib->From has a function definition of:
function From($from,$name=false){
And will use the $from and $name in outputting the From address as follows:
if ($this->mailfrom){
if ($this->mailfromname) $this->headers["From"] = $this->mailfromname." <".$this->mailfrom.">";
else $this->headers["From"] = $this->mailfrom;
}
So we don't need to combine the name and address ourselves. This patch makes the 1 line change which is much shorter than my explanation :-)
Cheers,
Eric
| Comment | File | Size | Author |
|---|---|---|---|
| simplenews.module.from_name.patch | 764 bytes | ejort |
Comments
Comment #1
DriesK commentedJust for the record: it's is not because I did't respond to your issues, that I'm not interested. I'm now changing Simplenews to support subscription to multiple newsletters, and the code is changing thoroughly. When I'm finished, I will try to include all your 3 patches, but I'll first have to investigate whether they still work properly with the new code.
thanks for your efforts!
Comment #2
DriesK commentedComment #3
osherl commentedComment #4
(not verified) commentedComment #5
DriesK commentedClosed because the automatic close feature in project module is broken, and the issue list is becoming cluttered.