Using the garland theme on a generic sandbox site I had up, I was experiencing erratic slideshow pausing when hovering over the slideshow images. It was so erratic that often I thought something was wrong with it. I figured this was what was fixed by hoverintent, until I installed it. Hoverintent is great, but it didn't solve the erratic starting & stopping of the slideshow.
The main issue I discovered was that the hover pause mechanism was happening when leaving or entering the #views_slideshow_main_... div. The problem was, that div was much larger than the image sizes. So in the included patch I've added img to the selector that assigns the pause/start mechanism. Now the slideshow acts as I expected, pause when hovering over slideshow image, continue once off the image.
I've also included in the patch a checkbox on the administration page to disable the hover pause mechanism. I need that functionality, though per view would be ideal. Or perhaps a setting for teaser verses full nodes - #222685: Option to not pause on hover. Either way I hope to improve on it.
I was also thinking that after pausing, the slide should use a much shorter delay than set. From a usability perspective, it just makes sense to give visual feedback of some kind quickly. The default 5 secs, though generally a reasonable delay, seems agonizingly long after pausing on an image for a minute. I move my mouse away, and that 5 secs seems to take 8 or 10.
Any thoughts?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | hover_pause.patch | 4.39 KB | scafmac |
| hover_pause.patch | 2.72 KB | scafmac |
Comments
Comment #1
scafmac commentedUpdated patch attached. Contains changes in previous patch, plus shorter delay when resuming slideshow after pause. It would be easy to make this a customizable delay, but the hardcoded value provides a nice prompt UI feedback when moving off of image.
Any thoughts? Feedback?
Comment #2
juroon commentedI can't get this patch to work. I've tried setting up a similar directory structure to what you used in the patch, but it still doesn't work for me. I'm not a patching expert, but Drupal patches usually work for me. This one keeps asking which "File to patch", and no matter which of the files and which of the paths I give it, it fails.
Comment #3
dragonwize commentedscafmac can you please re-roll this patch according to http://drupal.org/patch/create
Definitely need this so thanks for the work.
Comment #4
botrisPatch cannot be applied, using D6.
Tried Eclipse and Linux, keeps giving errors in both:
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff -urp views_slideshow_old/js/views_slideshow.js views_slideshow/js/views_slideshow.js
|--- views_slideshow_old/js/views_slideshow.js 2008-03-25 21:08:46.000000000 -0400
|+++ views_slideshow/js/views_slideshow.js 2008-07-07 11:41:20.000000000 -0400
--------------------------
Patching file views_slideshow/js/views_slideshow.js using Plan A...
Hunk #1 succeeded at 17.
Hunk #2 succeeded at 42.
Hmm... The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff -urp views_slideshow_old/views_slideshow.module views_slideshow/views_slideshow.module
|--- views_slideshow_old/views_slideshow.module 2008-03-25 21:08:46.000000000 -0400
|+++ views_slideshow/views_slideshow.module 2008-07-03 22:41:27.000000000 -0400
--------------------------
Patching file views_slideshow/views_slideshow.module using Plan A...
Hunk #1 FAILED at 142.
Hunk #2 FAILED at 355.
Hunk #3 FAILED at 366.
Hunk #4 FAILED at 374.
4 out of 4 hunks FAILED -- saving rejects to file views_slideshow/views_slideshow.module.rej
Hmm... Ignoring the trailing garbage.
done
No options showing up with this one....
Comment #5
i25 commentedHas anyone gotten the latest patch to work? Thanks.
Comment #6
naught101 commentedSubscribe
While I agree that the hover pause is too big, and needs to be customisable, please remove the "img" css selector. Plenty of people use this module to display nodes which aren't purely images, and it makes sense to use the hover pause over the text as well. I would suggest that you work with your padding/border/margins in your css so that you don't have such a big parent div.
Comment #7
redndahead commentedMoving to 2.x
Comment #8
fearlsgroove commentedThis is fixed with the cycle migration in 2.x-dev