Closed (fixed)
Project:
Internationalization
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jul 2008 at 06:01 UTC
Updated:
19 Aug 2009 at 22:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
ar-jan commentedAbsolutely important. But how does what you propose differ from what Filefield does now? It already suits my needs ;)
I have a custom node-type with a Filefield_Image defined. When I create a node in one language and upload an image, then translate it, the image is already there in the translation. But maybe I'm not understanding what you mean.
Comment #2
drewish commentedthat's what i get for posting without testing fully. you're right i it does seem to do that. i guess then the the issue really becomes making it optional.
Comment #3
ar-jan commentedI haven't tested extensively but so far it seems to work. Making it optional would be a good feature, +1
Comment #4
ar-jan commentedIf you're going to work on this, what I think would be a great feature for multilingual support is something of a 'synchronize afterwards' function, that shares files/images between the translations.
I wrote that it works for me, and it does, but only if I translate a node with an image already attached. If I translate the nodes and later add a file, it does not get shared, i18n/translation's synchronize function does not work here (although it gives an option ´synchronzie attached image')
Comment #5
drewish commentedi'd think that if you check this box all your translations would share the same files, uploading to one uploads to alll, deleting from one deletes from all, etc. i18n is in pretty poor shape right now and i think that now that translations are in core the module should offer some support for this.
i'm just getting my data migrated into filefield from upload module right now so i'll probably start working on this next week.
Comment #6
ar-jan commentedLooking forward to that ;)
Comment #7
aaron commentedthis should probably be more generic than just in filefield. there are many types of fields where you might want this optional functionality.
of course, i'm speaking without having touched i18n in over a year, so ignore me if that seems unreasonable.
Comment #8
dopry commentedWith the translations... The new version FileField does allow files to be shared between nodes... as for the relationships between the field data and the node, that is CCK's job.
Comment #9
ariachitect commentedStill, in current version 3.0-rc1 there is a bug (partly described in #4)
I added new file field for 'Story' content type & checked 'Synchronize translations' box for this field.
Then I created a new story & uploaded some files. When I created a translation - it had that files. But when I added a file to one translation, it didn't appear in the other.
It does not seems to be a CCK bug, because 'Synchronize translations' works for other fields, e.g. with 'link'.
Comment #10
quicksketchThis looks like an unfinished task within the i18n_sync.module:
Currently the logic is unimplemented.
Comment #11
Just1 commentedI just have this problem (need to synchronize filefield between my translations). I resolve the situation by simply commenting these 3 lines (264,265,266):
I do not know what was the logic to implement for filefield but it works well with the code included in the default case.
Ps: thanks quicksketch for pointing out where the problem was, that saved me a lot of search time.
Comment #12
der_tisch commentedI have followed just1's instructions and it seem to work.
But I wonder if this has any side effects. Maybe the authors of this module had some kind of intention when using the switch statement. Any ideas?
Comment #13
Martin Möhwald commentedCheck out dasjo´s patch: http://drupal.org/node/426478#comment-1764910
It worked for me. Could be a possible fix.
Comment #14
dasjohere is my patch from http://drupal.org/node/426478#comment-1764910 which treats filefield and imagefield equally.
Comment #15
Leonth commentedI got
warning: Invalid argument supplied for foreach() in [...]/drupal6/sites/all/modules/i18n/i18nsync/i18nsync.module on line 376.the first time I tried dasjo's patch at #14. But later synchronizing does not give the error anymore.I tried #10 and it also worked.
Comment #16
quicksketchUsing FileField 3.0 beta1 or higher (we're now at 3.1), it's unnecessary to differentiate between filefield and imagefield, since an imagefield now actually IS a filefield as far as data is concerned. ImageField is just a widget on top of the field provided by FileField. So you should be able to remove
case 'imagefield':entirely.Comment #17
jose reyero commentedOk, added some additional check (is_array) and committed. Thanks.