Download & Extend
Views Slideshow » Issues

Don't rotate if only one

Posted by linuxbox on July 9, 2008 at 6:23pm
Project:Views Slideshow
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi. If there is only one node displayed by the view, then the views_slideshow module has that node fade out and then fade back in. That doesn't look quite right. I want the ability to have the node stay put if there's only one.

This patch gives that ability.

AttachmentSize
views_slideshow-stop-if-one.patch603 bytes
Login or register to post comments

Comments

#1

Posted by Delta Bridges on July 22, 2008 at 3:43am

Great Patch... many thanks :)
Expat9

#2

Posted by linuxbox on September 5, 2008 at 8:49pm

Any chance of this getting reviewed and accepted soon? It makes me nervous to run forked code.

#3

Posted by anantagati on October 23, 2008 at 10:53am
Status:needs review» reviewed & tested by the community

Works good for me.

#4

Posted by redndahead on November 19, 2008 at 10:39pm
Status:reviewed & tested by the community» needs review

The current patch will still make ajax and mouse over calls even if there is only one. This patch should not allow it to not make any ajax or mouse over calls. D5 and D6 attached. I know this issue has been lingering for a while so hopefully we can get this back to rtbc status so aaron can patch when he's able to get back.

AttachmentSize
disable_rotate_5-1.patch 1.54 KB
disable_rotate_6-1.patch 1.47 KB

#5

Posted by will_in_wi on May 26, 2009 at 4:42am
Version:5.x-1.x-dev» 6.x-1.x-dev
Category:feature request» bug report

This is still an issue. I believe best practice is to target the most recent version and backport.

#6

Posted by redndahead on August 25, 2009 at 8:52pm
Version:6.x-1.x-dev» 6.x-2.x-dev

Moving to 2.x will look at this later

#7

Posted by redndahead on September 18, 2009 at 7:22pm
Status:needs review» fixed

This seems to be fixed in 2.x since we use the cycle plugin and it makes sure there is more than one before rotating.

#8

Posted by System Message on October 2, 2009 at 7:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#9

Posted by rootdownmedia on December 3, 2009 at 8:22pm

Still having this issue with 6.x-2.0-beta2

#10

Posted by rootdownmedia on December 5, 2009 at 8:12pm
Status:closed (fixed)» reviewed & tested by the community

Any ideas on how to set up cycle plugin so that this issue does not occur?

#11

Posted by redndahead on March 16, 2010 at 4:19am
Status:reviewed & tested by the community» postponed (maintainer needs more info)

I have verified that this doesn't happen in the latest version. Are you sure that your site is using the latest jquery cycle plugin?

#12

Posted by redndahead on March 31, 2010 at 7:49am
Status:postponed (maintainer needs more info)» fixed

Marking as fixed. Feel free to reopen if you still have the same issue.

#13

Posted by System Message on April 14, 2010 at 7:50am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#14

Posted by ocamp on June 12, 2011 at 1:14pm
Status:closed (fixed)» active

hi,

im having this issue.

I have a view block, put it in a panel. when I visit that panel the image still fades in and out even if theres only 1 image.

Thanks for any help

system specs

Views 6.x-2.12
Views Slideshow 6.x-2.x-dev
Views Slideshow: SingleFrame 6.x-2.x-dev
Views Slideshow: ThumbnailHover 6.x-2.x-dev

Drupal 6.19
GD library bundled (2.0.34 compatible)
Image module directories Exists (sites/default/files/images).
MySQL database 5.1.52
PHP 5.2.16
PHP memory limit 128M
PHP register globals Disabled
Panels operating in Legacy mode
SimpleXML Enabled
Unicode library PHP Mbstring Extension
Zlib library Enabled
cURL Enabled
jQuery UI 1.6

#15

Posted by redndahead on June 12, 2011 at 2:54pm
Status:active» closed (fixed)

Can you please open a new issue. This one has been closed for over a year.