Don't rotate if only one
linuxbox - July 9, 2008 - 18:23
| Project: | Views Slideshow |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Description
Hi. If there is only one node displayed by the view, then the views_slideshow module has that node fade out and then fade back in. That doesn't look quite right. I want the ability to have the node stay put if there's only one.
This patch gives that ability.
| Attachment | Size |
|---|---|
| views_slideshow-stop-if-one.patch | 603 bytes |
#1
Great Patch... many thanks :)
Expat9
#2
Any chance of this getting reviewed and accepted soon? It makes me nervous to run forked code.
#3
Works good for me.
#4
The current patch will still make ajax and mouse over calls even if there is only one. This patch should not allow it to not make any ajax or mouse over calls. D5 and D6 attached. I know this issue has been lingering for a while so hopefully we can get this back to rtbc status so aaron can patch when he's able to get back.
#5
This is still an issue. I believe best practice is to target the most recent version and backport.
#6
Moving to 2.x will look at this later
#7
This seems to be fixed in 2.x since we use the cycle plugin and it makes sure there is more than one before rotating.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.
#9
Still having this issue with 6.x-2.0-beta2
#10
Any ideas on how to set up cycle plugin so that this issue does not occur?