First password field is auto-filled in Firefox 3 - needs autocomplete="off"

flexman - July 9, 2008 - 19:58
Project:Protected node
Version:6.x-1.5
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Issue tags:autofill, Firefox 3, password
Description

Once I install the protected_node module, each time I attempt to create content, the title field of my node and the first password field are being automatically filled in with my Drupal site login credentials which have been saved in the browser (Firefox 3 on mac and also on PC). This poses a problem because if the user attempts to publish a new page without using the protected node, they get an error every time due to the fact that the Protected Node password fields do not match (the first field is filled in with my password from firefox and the second field is blank). Not to mention the annoyance of having to replace the title field each time with the actual page title.

#1

tolmi - October 14, 2008 - 09:47
Status:active» won't fix

This is not a protected_node issue. The field is being populated by Firefox because you enabled it to remember your password when you set it.

Please be more careful and don't enable password remember in your browser clueless!

#2

dalin - March 19, 2009 - 03:31
Title:Auto-fill fields» First password field is auto-filled in Firefox 3
Version:5.x-1.2» 6.x-1.4
Status:won't fix» active

The suggested solution of "don't save passwords" is not reasonable. I can't just tell clients "don't save your login password to your site".

We need to find out why does Firefox 3 auto-fill the field and not FF2? Will simply renaming the field name and/or class and/or ID help?

#3

tolmi - March 19, 2009 - 10:32
Status:active» won't fix

http://www.verysimple.com/blog/2007/03/07/forcing-firefox-to-obey-autoco...

If you think this is a bug, then please escalate this to the Drupal core issue tracker. This means that the profile pages are buggy as well (user module).

When Drupal core solves this, protected_node will support it. Protected node uses Drupal's infrastructure to render password fields (as well as any form), so this could work without a new release (and of course backwardly as well).

Still if you find out why exactly this is happening and can suggest a reasonable solution, I'm open to discuss this further.

Please reopen if you feel you solved the problem.

Thanks,
Mark

#4

fysa - April 20, 2009 - 18:51
Title:First password field is auto-filled in Firefox 3» First password field is auto-filled in Firefox 3 - needs autocomplete="off"
Version:6.x-1.4» 6.x-1.5
Status:won't fix» active

The autocomplete="off" attribute needs to be included on the password fields. This will keep Firefox from auto-completing the field if the password was saved.

#5

dalin - April 21, 2009 - 05:09
Status:active» needs review

Here's a patch.
You can't simply add an #attribute because the password_confirm FAPI element type doesn't pass attributes on to the password fields. Instead this uses an #after_build function to add the #attributes after expand_password_confirm() has done its work.

AttachmentSize
password_protect_no_autocomplete.diff 1.12 KB

#6

fabrizioprocopio - June 29, 2009 - 01:32

I too find this bug.
When create new node I find always my username as new element in the primary liks (can be solved deleting it in menu setting when create new content, but so annoying)
and then the some problem described yet: password stored in the first passwrod field.
I don't know how to apply the pacth, and I read around to not use patch expecially for user (like me) that doesen't know code and stuff like that. I'm not a coder. I'm just a Drupaler :-)

So my petition to the author of module is to integrate the patch in the module.
Thanks in advance for your time.

fab

#7

Amir Simantov - July 28, 2009 - 12:22

+1 for putting this code inside the module.

#8

thrash632 - August 9, 2009 - 04:53

+1 for putting this patch inside the module. Really annoying when it auto-fills the password field.

Otherwise an awesome module!

#9

sreese - August 26, 2009 - 17:22

The patch doesn't seem to work for Drupal 5.x. Is there a similar fix for the 5.x branch?

#10

sreese - August 26, 2009 - 18:03

It does work. I just had a conflicting version of the module in an odd subdirectory. My apologies.

#11

kees@qrios - September 9, 2009 - 10:56

Behaviour as outlined in #6 confirmed, extremely annoying.

Patch #5 confirmed as a working solution.

-------------------
Kerstbomen online kopen

 
 

Drupal is a registered trademark of Dries Buytaert.