Fixed in 6.x http://drupal.org/node/280571

Not checked if this applies to 7.x too, so marking to needs review.

CommentFileSizeAuthor
#12 locale-confirm-280628-7x-12.patch2.88 KBpwolanin
#7 locale-confirm-280628-7x-7.patch2.04 KBpwolanin
locale-confirm.patch2.81 KBcatch

Comments

pwolanin’s picture

pwolanin commented

note, this was part of SA-2008-044 for D6

Susurrus’s picture

Susurrus commented
Status: Needs review » Closed (duplicate)

Then duplicate of #280605: Apply SA-2008-044 fixes.

catch’s picture

catch
he/him
Primary language English
commented
Status: Closed (duplicate) » Fixed

Looks like it was committed by itself.

catch’s picture

catch
he/him
Primary language English
commented

This broke the locale test: http://drupal.org/node/282340

pwolanin’s picture

pwolanin commented
Status: Fixed » Needs work

this broke the locale module test for D7 (and D6?)

pwolanin’s picture

pwolanin commented

Also, the commit was apparently incomplete for D7 - the locale.inc part was missed: http://drupal.org/cvs?commit=126460

pwolanin’s picture

pwolanin commented
Category: task » bug
Status: Needs work » Needs review
StatusFileSize
new locale-confirm-280628-7x-7.patch2.04 KB

just marked this issue duplicate: http://drupal.org/node/282340

Attached patch adds the code to locale.inc that was apparently missed in the commit AND fixes the test.

see: http://drupal.org/node/283201 and http://drupal.org/node/276153 for other patches for locale.module

cwgordon7’s picture

cwgordon7 commented
Status: Needs review » Needs work

Upon trying to install with this patch applied, I get the following error:

( ! ) Fatal error: Unsupported operand types in C:\Tools\wamp\www\drupal\stf\pwlocale\modules\locale\locale.module on line 536
Call Stack
# Time Memory Function Location
1 0.0094 464536 {main}( ) ..\install.php:0
2 0.0191 680736 install_main( ) ..\install.php:1163
3 1.9040 7005944 install_tasks( ) ..\install.php:142
4 3.2185 10452440 theme( ) ..\install.php:820
5 3.2187 10463024 call_user_func_array
( )		 ..\theme.inc:645
6 3.2187 10463024 template_preprocess_maintenance_page( ) ..\theme.inc:0
7 3.2782 10475688 drupal_get_js( ) ..\theme.maintenance.inc:262
8 3.2782 10478264 locale_update_js_files( ) ..\common.inc:2039

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review

odd- I don't get the same error. Are you installing as non-English? Why is locale module even enabled during install?

catch’s picture

catch
he/him
Primary language English
commented

I don't know - probably the only way to ensure a translation will work if it's used? - but it makes the 'expert' install profile a bit crufty since I had to disable it as one of the profile tasks.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

I can install fine, there's no test hunk in #7 and the test still has two failures without it though. Was that just missing from the patch?

I also got an obscure "tests not completed successfully" error the first time running tests, but it was fine the second time so will forget that for now unless it can be reproduced.

pwolanin’s picture

pwolanin commented
Status: Needs work » Active
StatusFileSize
new locale-confirm-280628-7x-12.patch2.88 KB

hmm, apparently I diffed wrong and didn't get the test hunk (and of course, I reverted those changes already). Ok, trying again.

pwolanin’s picture

pwolanin commented
Status: Active » Needs review

missed in the drop-down. Needs review.

cwgordon7’s picture

cwgordon7 commented
Title: locale.module missing confirm form » locale.module missing confirm form
Status: Needs review » Reviewed & tested by the community

Unable to reproduce the bug I had earlier with the new patch, in any case. Locale tests now pass with this patch. RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.