I tried to add this module to Drupal.hu, now after the 6.3 upgrade but it fails miserably. There are some menus with dropdowns which repeat items lots of times and also the admin menu itself contains hordes of items.

Tried to clean the menu cache (eg. modules page), switch to English localization, but same happens. I don't know what might be the issue here.

Comments

sun’s picture

Strange. Did you try the latest development snapshot for 6.x already?

gábor hojtsy’s picture

No yet. Will do later.

sun’s picture

I've just double-checked that we didn't overlooked Locale module during the port. However, after enabling another locale and importing language files I'm still unable to get this result.

Since #277746: issue queue explosion has been marked as duplicate of this issue, I really wonder whether you might have another contrib module installed that screws up the menu.

sun’s picture

Status: Active » Postponed (maintainer needs more info)

Now I even installed the Hungarian language to ensure this bug is really not caused by Locale.

pwolanin’s picture

@Gabor - did you run one of the beta versions of the module?

Also, the repeated items could be local tasks - which this module tries to put into the menu. Do you have, for example, an additional translation module that makes lots of local tasks? It's possible that in combination with i18n or some there needs to be additional tweaking of the links, perhaps with hook_menu_link_alter().

As an intermediate step - delete from {menu_links} where menu_name = 'admin_menu', and then hit (e.g.) the modules page to get a rebuild.

webastien’s picture

I encountered the same problem with sites which were accessible with / without the www (before I modify the htacess).
The only duplicated entry was the favicon, your solution regulated the problem.

Thx

keesje’s picture

Duplicate favicon confirmed.
Solved after removing admin_menu links from dbs & empty menu cache.

Kees

webastien’s picture

The problem is coming back... :(

pwolanin’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new1.32 KB

Well, here's a patch that just adds the ability to wipe and rebuild with a button on the settings page.

I'm really not sure how this duplication is happening - perhaps you could list which contrib modules you are using.

sun’s picture

cdale identified a similar cause for this duplication over at #285061: Two icons in the upper left corner, which I was able to replicate.

Simply changing the site_frontpage variable to another path will cause a duplicated admin_menu icon in the upper left corner. I guess that means, this will happen each time a menu item changes - a stale, original item is still present in admin_menu while a new one is added. IIRC, language/i18n also happens to alter menu items, so this could be the cause for both issues. If it is, then #285061 should be marked as duplicate of this issue.

sun’s picture

For the sake of completeness here's a db export of this data:

INSERT INTO `menu_links`
(`menu_name`, `mlid`, `plid`, `link_path`, `router_path`, `link_title`, `options`,
`module`, `hidden`, `external`, `has_children`, `expanded`, `weight`, `depth`, `customized`,
`p1`, `p2`, `p3`, `p4`, `p5`, `p6`, `p7`, `p8`, `p9`, `updated`)
VALUES 
('admin_menu', 12075, 0,      'node',      'node',        '<img...>',   'a:3:...',
'admin_menu', 0, 0, 0, 0, -100, 1, 0,
12075, 0, 0, 0, 0, 0, 0, 0, 0, 0),
('admin_menu', 12390, 0,      'node/2',    'node/%',      '<img...>',   'a:3:...',
'admin_menu', 0, 0, 1, 0, -100, 1, 0,
12390, 0, 0, 0, 0, 0, 0, 0, 0, 0);
pwolanin’s picture

Ok, well having this button available would be handy in any case - but if the actual cause is a change in the frontpage path, we should be able to handle that, I think.

keesje’s picture

Hi Sun,

I can confirm this. The icon is duplicated after homepage change.

Kees

pwolanin’s picture

StatusFileSize
new2.99 KB

here's a patch that also tries to track changes to the front page setting. minimally tested - please test

sun’s picture

Hm. This does not "feel" like the right solution, resp. a fix for the cause. That said, the amount of bug reports for 6.x alerts me and leads to the assumption that 6.x-1.0 was released too early. Unfortunately, I'm still buried with a lot of work in a D5-based project, so I won't be able to investigate all of these (possibly related) bugs shortly.

#285061: Two icons in the upper left corner
#287468: Paths directly under /admin added by modules get the wrong parent.
#282065: no menu display when enabled organic group module
#287448: Breaks LoginToboggan
#282030: Showing menu entries that user does not have permission to view

pwolanin’s picture

Status: Needs review » Needs work
gábor hojtsy’s picture

Re @pwolanin at #5: Running delete from {menu_links} where menu_name = 'admin_menu' solved my issue at drupal.hu. Turning the module back on now works nicely. This issue practically derailed into other problems as well, so I am not sure I should close it or not :| As far as I am concerned, our issue is solved by clearing the cache, and will use and monitor the module for any problems of course.

sun’s picture

Status: Needs work » Closed (duplicate)

Thanks for your feedback, Gábor.

Marking as duplicate of #295476: admin_menu conflicts with pathauto.

Please re-open this issue if this bug occurs again.