Block problems

NancyDru - July 14, 2008 - 15:42
Project:Web Links
Version:HEAD
Component:Code
Category:bug report
Priority:normal
Assigned:NancyDru
Status:closed
Description

There are some devel debugging lines (dsm) in hook_block that fail and make the Admin screen go white.

AttachmentSize
weblinks29.patch715 bytes

#1

NancyDru - July 14, 2008 - 16:32

You can remove them if you want, but I have a better patch coming...

#2

NancyDru - July 14, 2008 - 16:43
Title:Debugging code causes Admin to WSOD» Block problems
Priority:critical» normal

In addition to the above, the fix for http://drupal.org/node/131416 got changed and did not work. Also, it was only to the "recent" block. This patch extends that setting to all blocks (including even the upcoming "popular" block).

Note the code has been refactored to improve readability and extensibility.

The query code has a small change that opens a nice new feature ... coming soon.

AttachmentSize
weblinks29.patch 5.88 KB

#3

NancyDru - July 14, 2008 - 17:44

Stop me, I'm out of control!!! In a few minutes, I'll throw in the "most popular" block while I'm, here.

#4

rmiddle - July 14, 2008 - 18:32

ops I put debuging code into cvs. my mistake. Sorry.

#5

NancyDru - July 14, 2008 - 18:34

Hopefully, I'll leave this alone for a little while... All the above, plus the "Most popular" request.

AttachmentSize
weblinks29.patch 7.89 KB

#6

NancyDru - July 15, 2008 - 02:43
Status:needs review» patch (to be ported)

committed to 6.x

#7

rmiddle - July 15, 2008 - 05:08
Status:patch (to be ported)» fixed

Backported to 5. Commited to CVS.

#8

NancyDru - July 15, 2008 - 05:22
Status:fixed» closed

Since I reported it and no one else seemed to notice, let's clear up the issue.

#9

rmiddle - July 15, 2008 - 05:32

No one noticed as the dsm code went in after alpha9 was released so that debuging code only appeared in CVS.

Thanks
Robert

 
 

Drupal is a registered trademark of Dries Buytaert.