Hooks for comment enhancements

When applied to CVS (2005-08-13):
(lucas@bsd1)/www/koorneef/test.koorneef.net/modules$ patch < comment.module_10.patch
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: modules/comment.module
|===================================================================
|RCS file: /cvs/drupal/drupal/modules/comment.module,v
|retrieving revision 1.364
|diff -u -r1.364 comment.module
|--- modules/comment.module 1 Aug 2005 05:14:05 -0000 1.364
|+++ modules/comment.module 5 Aug 2005 05:19:14 -0000
--------------------------
Patching file comment.module using Plan A...
Hunk #1 failed at 434.
Hunk #2 failed at 1417.
Hunk #3 failed at 1427.
Hunk #4 failed at 1469.
Hunk #5 succeeded at 1699 with fuzz 2.
4 out of 5 hunks failed--saving rejects to comment.module.rej
done

I'll see if I can update the patch ...

Found the problem: the patch file had DOS format line-endings. Corrected in new version: 11.

Patch applies, but captcha is not appearing on comment form (it did with the older patches, see http://drupal.org/node/14708). Have to investigate further ....

i think consistency with nodeapi is important, so no 'form' operation ... this patch looks simple and useful to me.

+1 for consistency; we can (I will) modify captcha to form_post once this hits core.

In the beginning comments were supposed to be simple texts.. If you add files, how do you display without 'load' and 'view' operations? If you add 'load' and 'view', then why not create a 'comment' node type?

Important notice: if this gets in, then project module can be overhauled to use the comment system!

qualified +1: I have looked over but not applied this patch.

I like the added functionality. In general, it helps move us toward parallelism between different object types--which is good. My feeling is: unless there's a good reason *not* to expose a particular Drupal object type (comment, term, vocabulary, user, for a start) to nodeapi-like hooks, we should do so. If someone wants to do it with nodes, likely there's a good use case with other object types. Case in point: I'm continually frustrated with the inability to act on taxonomy term views (my patch, http://drupal.org/node/10399, a year ago, went nowhere, but maybe I should revive it).

Why not just use a node type? Because nodes are for different things than comments--twisting them into comments is bad practice.

The potential to use this for project.module, as suggested, is an added bonus.

A question about last patch: in db_query("UPDATE {node_comment_statistics} SET comment_count = %d, last_comment_timestamp = %d, last_comment_name = '%s', last_comment_uid = %d WHERE nid = %d", 0, NULL, 0, 0, $nid); why do you use NULL for last_comment_timestamp if it'd %d? It will be changed to '0', so if you want to use reall sql NULL type you need to put it directly.

Ah, didn't pay attention to the fact that it's not changed in patch... sorry about that. Happens sometimes to me ;)

Any hope of a patch for 4.6.3? This is really useful.

your patch for 4.6.3 is again in DOS format...
also, none of these patches works for 4.6.2 :(

I'm working on task.module and I wanted to provide task updates through comments. This patch did the trick and was such a big time saver (thanks to killes for recommending it).

However, I do have a feature request for this patch. I'd be nice if you could pass $comment by reference, so that I could use 'validate' to validate and update certain values. This way when 'view' is executed $comment will already have the validated data and I want have to call my hook_validate function again. This will mimic the way node hooks work, for example hook_validate passes $node by reference.

Also, update your patch to include the newest comment.module changes. The main one being the removal of ?> at the end of the file.

All in all, I give this patch a +1 for it's usefulness. Thanks!

I downloaded the patch and checked it against my comment upload module and the thing works.

I'll commit this if someone takes the time to move all the comment moderation stuff out of core into a separate module (by using this patch). Given such API, this is a logical clean-up. It would help validate the usefulness of this patch.

This is what I'm getting when trying to install this patch. I'm trying to get CAPTCHA to work.
--------------------------
|Index: modules/comment.module
|===================================================================
|RCS file: /cvs/drupal/drupal/modules/comment.module,v
|retrieving revision 1.369
|diff -u -r1.369 comment.module
|--- modules/comment.module 7 Sep 2005 20:45:53 -0000 1.369
|+++ modules/comment.module 13 Sep 2005 23:44:28 -0000
--------------------------
Patching file comment.module using Plan A...
Hunk #1 succeeded at 25 with fuzz 1 (offset -6 lines).
Hunk #2 succeeded at 46 (offset -6 lines).
Hunk #3 succeeded at 89 with fuzz 2 (offset 4 lines).
Hunk #4 succeeded at 108 (offset -7 lines).
Hunk #5 succeeded at 205 (offset 4 lines).
Hunk #6 failed at 288.
Hunk #7 failed at 392.
Hunk #8 succeeded at 490 (offset -52 lines).
Hunk #9 succeeded at 636 (offset 4 lines).
Hunk #10 failed at 643.
Hunk #11 succeeded at 647 (offset -52 lines).
Hunk #12 succeeded at 711 (offset 4 lines).
Hunk #13 succeeded at 674 (offset -52 lines).
Hunk #14 succeeded at 750 (offset 4 lines).
Hunk #15 failed at 846.
Hunk #16 succeeded at 808 (offset -52 lines).
Hunk #17 succeeded at 883 (offset 4 lines).
Hunk #18 failed at 983.
Hunk #19 succeeded at 1053 (offset 3 lines).
Hunk #20 failed at 1076.
Hunk #21 succeeded at 1109 with fuzz 2 (offset 8 lines).
Hunk #22 failed at 1119.
Hunk #23 failed at 1138.
Hunk #24 failed at 1169.
Hunk #25 failed at 1182.
Hunk #26 failed at 1196.
Hunk #27 failed at 1205.
Hunk #28 succeeded at 1211 (offset -4 lines).
Hunk #29 succeeded at 1273 (offset 8 lines).
Hunk #30 succeeded at 1271 (offset -57 lines).
12 out of 30 hunks failed--saving rejects to comment.module.rej
done

I'm using 4.6.0 and none of the patches seem to work. I've updated my comment.module to the 4.6.3 release and the 4.6.3 patch doesn't work either.

Doesn't work for me on 4.6.3 either.

I am on 4.6.4, which version of the patch I should use for using captcha in comment modules?

I'm using 4.6.5 and my comment.module shows following Id string:
// $Id: comment.module,v 1.347.2.8 2005-11-15 20:37:56 dries Exp $

Which patch should I be using?

Thanks,

Can someone please let me know what patches I should apply to comment module to make captcha work with comment?

Drupal Version 4.6.5

If I have my wits right, users of Drupal Version 4.6.5 cannot use any of the aforementioned patches for the comments module.

This is because the comments.module 4.6.5 is dated Nov 16, 2005 while the previously mentioned patches ante-date this. I'll see if I can contribute a fix by hacking the most recent patch that tries to include the captcha module for 4.6.5.

4.6 does not get new features and new hooks are definitely features. Do not reopen issue. Thanks.

loloyd - hello, I am hoping you are making progress on this issue. I have sent you a message, and hope you will see it. Thanks,

learndrupal