As per subject, anyone had this?

Cheers,
G

CommentFileSizeAuthor
#5 add_js_fix.patch1.21 KBd.clarke

Comments

cnolasco’s picture

cnolasco commented

I have the same problem
the error:
addtofavorites is not defined
onclick(click clientX=0, clientY=0)
// JQuery 1.1.2

dan.thompson’s picture

dan.thompson commented

Same problem here. Firefox 3.0.10 on Ubuntu Linux. Although I get no error message, clicking the link just doesn't do anything. Although in this case I am using the 6.x-1.2 version of the module.

socialnicheguru’s picture

socialnicheguru commented

I can't get this to work in any browser

mynhed’s picture

mynhed commented
Version: 5.x-1.x-dev » 6.x-2.1

I can only get V2.1 to work in IE but not in Firefox 3.0.15 nor in Safari. Any suggestions?

d.clarke’s picture

d.clarke commented
Status: Active » Needs review
StatusFileSize
new add_js_fix.patch1.21 KB

I think the issue is that Drupal's block caching is preventing the drupal_add_js function from being called on each page render. A similar issue has been reported on views slideshow (http://drupal.org/node/404894) and fivestar (http://drupal.org/node/364764). Attached is a patch that solves the issue using the same solution that was implemented in those other modules... basically adding the JS to every page... not ideal but its the best we can do until Drupal's core JS caching changes.