This is caused because a missing Parenthesis in "OR" condition in line 1470 of hierarchical_select.module
Currently:
if ($config['editability']['status']
&& $config['editability']['allow_new_levels']
&& $config['editability']['max_levels'] == 0 || count($hierarchy->lineage) < $config['editability']['max_levels']
&& module_invoke($config['module'], 'hierarchical_select_valid_item', end($hierarchy->lineage), $config['params'])
&& module_hook($config['module'], 'hierarchical_select_create_item'))
{
It should be:
if ($config['editability']['status']
&& $config['editability']['allow_new_levels']
&& ($config['editability']['max_levels'] == 0 || count($hierarchy->lineage) < $config['editability']['max_levels'])
&& module_invoke($config['module'], 'hierarchical_select_valid_item', end($hierarchy->lineage), $config['params'])
&& module_hook($config['module'], 'hierarchical_select_create_item'))
{
patch attached.
Comments
Comment #1
javi-er commentedComment #2
wim leersGood catch! Next time, please roll your patch using CVS, and against CVS HEAD though ;) Your patch was already outdated (fast development pace!).
Committed.
Comment #3
wim leers(I initially forgot to credit you, I cancelled the commit-in-progress successfully, at least my CVS client said so, but it seems it got through anyway. My apologies!)
Comment #4
javi-er commentedAwesome! sorry about the outdated diff, it's my first patch and I wasn't sure how to make it :)
Comment #5
wim leersYou did a pretty good job if it was your first ;) :)
Thanks again!
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.