Hi. I've got a page with two images in it. One, I inserted using the filter tag. The other, I inserted using HTML code. Both were inserted with the drupalimage plugin. I'm using Drupal 5.7, Image 1.9, Img_assist 1.6.

When I click on an image and click drupalimage's camera icon, I expect a popup to come up, letting me adjust the properties of the image.

In fact, this happens when the image I clicked on was the one I did with the filter-tag.

But when I do this with the one I added using the HTML code, nothing at all happens. Not even an error on my js console.

Comments

Anonymous’s picture

Anonymous (not verified) commented

Also: TinyMCE module 1.9 and TinyMCE 2.1.2.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Won't work on non-filter-tag » Remove HTML tag feature
Version: 5.x-1.6 » 6.x-2.x-dev
Component: TinyMCE Plugin (drupalimage) » Code
Assigned: Unassigned » sun
Category: bug » task

Yes, that's the expected behavior. If you use HTML output instead of inline tags, Image assist is unable to parse and re-assign the rendered information back to a node relationship. You should only use the inline filter tags if you want to be able to alter embedded images again.

Thanks for reminding me of this caveat - I always wanted to drop this feature and 2.x is finally a very good place to do this.

Anonymous’s picture

Anonymous (not verified) commented

I thought you used to be able to edit images added with HTML.

I think that, rather than remove this feature, it could be made to work. The stuff stored in the pipe-delimited stuff could instead be stored in the class. Only local images are allowed.. Link could be read off by going to the dom parent.

That would allow you to actually be able to see the images in the wysiwyg editor, and therefore, wys would by more like wyg.

Give me the go-ahead and I'll code this up. I can probably do it this weekend.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

No, that was never supported.

The long-term goal for Image assist is to use Inline API. While Inline API could support alternative syntaxes (i.e. <anytag attribute="anyvalue" /> instead of [anytag|attribute=anyvalue]), such a syntax would require additional support to filter out attributes that should not be displayed in output (i.e. arbitrary DOM-attributes or additional class attribute values as seen in aforementioned examples, resp. like you suggested here). Well, on another thought, all of this would be possible, but not currently now.

So if you really want to code something up, I'd suggest to start with implementing support for alternative syntax parsers/renderers in Inline API (i.e. Inline 2.x). Because if we would implement this feature now in Image assist, migrating IA to use Inline API would become even harder than it is already.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Remove HTML tag feature » Remove HTML output feature
niftyc’s picture

niftyc commented

The HTML output is very useful. If people want HTML output, they probably can use HTML. I use HTML output and I don't want to let img_assist help me edit the HTML. I expected the current behavior of img_assist and never saw this as a bug. Please keep the HTML output if possible. You do not need to have img_assist edit it.

idflorin’s picture

idflorin commented

me too. Please keep the HTML output if possible. It's the best input for site users without to much experience.

z.stolar’s picture

z.stolar commented

People who're using rich text editors expect them to behave a certain way (e.g. - add HTML). I think it will be bad to take this option away.
-1 for removing html output.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

People using client-side editors are using Wysiwyg API, for which Image Assist provides a very tight integration.