Closed (fixed)
Project:
Hierarchical Select
Version:
5.x-3.x-dev
Component:
Code - Taxonomy
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
18 Jul 2008 at 20:19 UTC
Updated:
4 Aug 2008 at 15:52 UTC
Jump to comment: Most recent file
Comments
Comment #1
wim leersI suppose you want to use it just for the dropbox then? I've been thinking about this too.
But you are aware that it won't be very scalable, right?
In fact, no changes at all would be necessary, only remove the hierarchy check. I've attached a patch that does this, please give it a try :)
Comment #2
jrbeemanPatch works for me. The UI experience ends up being a little weird with a single-level list, as it attempts to find children of the selected item and therefore greys out the selection for a moment (I think this is the scalability issue you're mentioning, as it performs additional server hits), but the bonus of a consistent, and nice user experience is worth the trade-off, in our case. This seems to be a usability improvement for admins, as well, because I think most admins will believe that checking the HS box to enable it will do so, regardless of whether the taxonomy is set to be hierarchical.
Comment #3
wim leersAgreed on everything you said.
Except for one. The scalability issue I was referring to, is that when you have a huge single-level vocabulary (say 10,000 terms), this'll be very slow. But that's up to the site maintainer: he should make it a hierarchy then!
I agree that HS should be smarter: it should only try to update when it's known that an item has children. I created an issue for that: http://drupal.org/node/284739.
Will commit this later today. Thanks for testing!
Comment #4
wim leersCommitted a slightly improved patch!
Comment #5
jrbeemanFantastic, thanks!
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.