Posted by linuxbox on July 22, 2008 at 1:44pm
Jump to:
| Project: | Fivestar |
| Version: | 5.x-1.12 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi. I set up my fivestar to show the active widget above the node. I don't allow anonymous votes. When an anonymous user views the page, the fivestar static widget appears below the node.
The problem is in the nodeapi view function, when it's deciding whether to give it weight -10 or +50. The switch($position) falls through the 'above'/'below' case if the user doesn't have access. Then the 'above_static' case only checks if $position is 'above_static'. This patch changes it so that it checks if $position starts with 'above', to support this fall-through case.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| position.diff | 707 bytes | Ignored: Check issue status. | None | None |
Comments
#1
Thanks! I committed to both 5 and 6 branches.
#2
Automatically closed -- issue fixed for two weeks with no activity.