A couple minor issues in the mailhandler.retrieve.inc error handling code need fixing/refactoring:

1) error messages are being generated for both display in watchdog (html) and email message (plain text). ideally you wouldn't have html entities showing up in an email so these should be different strings.

2) error messages are being translated before going into watchdog(); watchdog should get an untranslated string and variables array.

So the email message should get translated plain text and watchdog should get untranslated html and variables.

CommentFileSizeAuthor
#1 mailhandler-retrieve.patch9.51 KBmfb

Comments

mfb’s picture

mfb
they or he
commented
Title: mailhandler.retrieve.inc error handling needs some tweaks » mailhandler.retrieve.inc error handling cleanup
Status: Active » Needs review
StatusFileSize
new mailhandler-retrieve.patch9.51 KB

This might need more work but I fixed up the above issues and also fixed some undefined variables which were causing PHP notices.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

committed. thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.